AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071009163445.4817d45d@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<jeff.miller@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAILgsEkmHMbXL6A000001e0@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 9 Oct 2007 16:34:58 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Jeff Miller <jeff.miller@onstor.com>
Subject: Re: PERFORCE change 25776 for review
Message-ID: <20071009163458.4b53b174@ripper.onstor.net>
In-Reply-To: <WEBMAILgsEkmHMbXL6A000001e0@mail.onstor.com>
References: <WEBMAILgsEkmHMbXL6A000001e0@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On 9 Oct 2007 16:29:05 -0700 Jeff Miller <jeff.miller@onstor.com> wrote:

> Change 25776 by jeffm@jeffm-dev on 2007/10/09 11:28:07
> 
> 	Some refinements to Cougar data netwark statistics.
> 	Removed 'collision' stats.
> 	Changed 'fsc' to 'fcs' since it stands for 'frame check
> sequence' Change 'crc' to 'fcs' in display to be consistent
> 	Change 'PHY code errors' to 'code errors' - I doubt knowing
> that they are detected by the PHY rather than MAC is helpful.
> Reviewed by: rendellf Regression: should only affect Cougar, changes
> are only in txrx net statistics code.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-bmc12500-eth/bmc12500-eth-api.h#3
> edit ... //depot/dev/nfx-tree/code/sm-bmc12500-eth/bmc12500-eth-diag.c#4
> edit ... //depot/dev/nfx-tree/code/sm-stats/stats-txrx.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_stats.c#9 edit
> 
> 
> http://liszt:1818/@md=d&cd=//depot/$c=G35@/25776?ac=10

for cmd_stats.c:

line 295, no need to print out fcs errors twice (line 298)
what happened to regular, late and excessive collisions?  do we not
collect those on either bobcat or cougar?