AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071016174734.28011335@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E060D153C@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 16 Oct 2007 17:47:55 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: PERFORCE change 25871 for review
Message-ID: <20071016174755.5bfeed91@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E060D153C@onstor-exch02.onstor.net>
References: <WEBMAIL43i7pwKuX9aj00000fc5@mail.onstor.com>
	<20071016173335.741bfead@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E060D153C@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Forget about it until you get back.  There is a caveat rule: if it's
during pub hours in England, you don't have to comply.

I wish that the comments could be edited after the fact, I'd do it to
my own all the time.

On Tue, 16 Oct 2007 17:39:14 -0700 "Ed Kwan" <ed.kwan@onstor.com> wrote:
> So how do I edit it?
> It's 1:37am in London, and I don't think I've read your "cute" email
> yet...
> 
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Tuesday, October 16, 2007 5:34 PM
> > To: Ed Kwan
> > Subject: Re: PERFORCE change 25871 for review
> > 
> > On 16 Oct 2007 17:19:09 -0700 Ed Kwan <ed.kwan@onstor.com> wrote:
> > 
> > > Change 25871 by edk@edk-r310rel on 2007/10/16 12:15:42
> > >
> > > 	Integrating change 25825 for TED 20712 into the R3_1_0_rel
> > > 	branch.
> > > 	Reviewed by chrisv.
> > >
> > > Affected files ...
> > >
> > > ... //depot/R3_1_0_rel/nfx-tree/code/ssc-nfxsh/cmd_nfs.c#5
> > > integrate
> > 
> > Hi Ed,
> > 
> > Perhaps I was trying too hard to be cute before, and perhaps you've
> got
> > a lot going on right now, but the convention that we all need to
> follow
> > for check in comments is, amongst other things, to not require the
> > use of this or any other tool to know what the checkin was about.
> > Even
> for
> > release or maintenance branches.  Please try to follow the
> > convention. I know you've probably got a lot going on right now and
> > we all goof it some times.  That's why we have to police each
> > other, in order to stay on track.
> > 
> > This was an integrate, so it should be easy to just cut and paste
> > the original checkin comment; or you can summarize the original
> > comment if you want, say for instance, if it's huge and you don't
> > want to paste the whole thing.
> > 
> > Thanks,
> > 
> > a
