AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070116152556.2b70c2d9@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 16 Jan 2007 15:39:55 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: review comments for verify_install.sh
Message-ID: <20070116153955.6f8c2ceb@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_p65suaRMBx/hJ.=sM7c7wPr"

--MP_p65suaRMBx/hJ.=sM7c7wPr
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Larry,

Well, it looks like you have a bit of work to do yet.  There is no
error handling in the script, and the u/mount-secondary parts have to
be redone.  Attached is the comments I've typed up so far.  I think the
best thing to do is address these first, and then re-review.

Thanks,

a


--MP_p65suaRMBx/hJ.=sM7c7wPr
Content-Type: text/plain; name=verify_install.sh-review.comments
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=verify_install.sh-review.comments

UmV2aWV3IGNvbW1lbnRzIGZvciB2ZXJpZnlfaW5zdGFsbC5zaA0KDQo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K
DQpFc3NlbnRpYWxzOg0KDQo8PElURU0+Pg0KVGhlcmUgaXMgYSBkaXJ0aCBvZiBlcnJvciBoYW5k
bGluZy4gIFRoZSBleGl0IHN0YXR1cyBvZiBhbG1vc3Qgbm8NCmNvbW1hbmRzIGlzIGNoZWNrZWQs
IGFuZCBubyBleHBsaWNpdCByZXR1cm4gdmFsdWVzIGZyb20gZnVuY3Rpb25zIGlzDQpwZXJmb3Jt
ZWQsIG9yLCBvYnZpb3VzbHksIGNoZWNrZWQuICBUaGlzIG5lZWRzIHRvIGJlIGZpeGVkLg0KDQo8
PElURU0+Pg0KZnVuY3Rpb24gZG93bmxvYWQ6IGl0IGV4dHJhY3RzIHRoZSB0YXJiYWxsIGludG8g
YSBtZW1vcnkgZmlsZSBzeXN0ZW0uDQpJIHRob3VnaHQgd2Ugd2VyZW4ndCBnb2luZyB0byBkbyB0
aGF0IGFueW1vcmUuICBUaGF0IHdhcyBraW5kYSB0aGUgcG9pbnQuDQpJIHNlZSB0aGF0IHlvdSBo
YXZlIGFub3RoZXIgZnVuY3Rpb24sIHNvIHdoeSBoYXZlIGRvd25sb2FkPyAgQXhlIGl0Lg0KDQo8
PElURU0+Pg0KZnVuY3Rpb24gbW91bnRfc2Vjb25kYXJ5OiBuZWVkcyB0byBiZSBkeW5hbWljIGJh
c2VkIG9uIHRoZSBmc3RhYiBmaWxlDQpsb2NhdGVkIG9uIHRoZSBzZWNvbmRhcnkgZmxhc2guICBT
YW1lIGdvZXMgZm9yIHVtb3VudF9zZWNvbmRhcnkuICBUaGUNCmJlc3QgdGhpbmcgdG8gZG8gaXMg
YXNzdW1lIHRoYXQgc3VjaCBtb3VudHMgYXJlIHN0YXRlZnVsLCBhbmQgc3RvcmUNCnRoZSBpbmZv
cm1hdGlvbiBhYm91dCB0aGUgbW91bnRzIHRoYXQgeW91IGRvLCBhbmQgdGhlbiBkbyB0aGUgdW5t
b3VudHMNCmJhc2VkIG9uIHRoYXQgc3RvcmVkIGluZm9ybWF0aW9uLg0KDQpDaGVjayB0aGUgZXhp
dCBzdGF0dXMgb2YgdGhlIG1vdW50IGNvbW1hbmRzLCBhbmQgZmFpbCBpZiB0aGV5IGZhaWwsDQpy
YXRoZXIgdGhhbiBqdXN0IGFzc3VtaW5nIHRoYXQgdGhleSBzdWNjZWVkLiAgQW5kIHVtb3VudCB0
aGUNCnBhcnRpdGlvbnMgdGhhdCBtYXkgaGF2ZSBiZWVuIG1vdW50ZWQgc28gZmFyLiAgU2tpcCB0
aGUgcHJlZW1wdGl2ZQ0KdW5tb3VudHMgYXQgdGhlIGJlZ2lubmluZy4gIFRoZSBzZWNvbmRhcnkg
c2hvdWxkIG5vdCBhbHJlYWR5IGJlDQptb3VudGVkLiAgRmFpbCBpZiBpdCBpcy4gIEFuZCBtYWtl
IHN1cmUgdGhhdCB5b3VyIHNjcmlwdCBuZXZlciBleGl0cw0KbGVhdmluZyB0aGUgc2Vjb25kYXJ5
IG1vdW50ZWQuDQoNClRoZSBjaGVja19zZWNvbmRhcnkgYWxzbyBtdXN0IGJlIGJhc2VkIG9uIHRo
ZSBmc3RhYiBmaWxlIGZvdW5kIG9uIHRoZQ0Kc2Vjb25kYXJ5LCBub3Qgc29tZSBoYXJkIGNvZGVk
IHRoaW5nIGluIHlvdXIgc2NyaXB0Lg0KDQpUaGlzIHVwZ3JhZGUgY29tbWFuZCBoYXMgdG8gd29y
ayBldmVuIHdoZW4gdGhlIGZzdGFicyBhbmQgcGFydGl0aW9ucw0KZG9uJ3QgbWF0Y2ggYmV0d2Vl
biB0aGUgcHJpbWFyeSBhbmQgc2Vjb25kYXJ5IENGIGNhcmRzLiAgUmVtZW1iZXIsDQp3ZSBhcmUg
bW92aW5nIHRvIGEgbmV3IHBhcnRpdGlvbiBsYXlvdXQgaW4gRGVsb3JlYW4sIHNvIHRoaXMgdXBn
cmFkZQ0Kc2NyaXB0IGhhcyB0byBiZSBwYXJ0aXRpb24gbGF5b3V0IG5ldXRyYWwuDQoNCkxpbmUg
NTQ5OiBzYW1lIGRlYWwuICBHZXQgdGhlIG1vdW50IGluZm9ybWF0aW9uIGZvciAvdmFyIGZyb20g
dGhlDQpmc3RhYiBmaWxlLiAgWW91IGRvbid0IG5lZWQgdG8gbW91bnQgdGhlIHJvb3QgcGFydGl0
aW9uIGF0IGFsbC4NCg0KPDxJVEVNPj4NCmxpbmUgNTYzOiB5b3UgYXJlIHJlc3RhcnRpbmcgcG0g
dG8gZG8gYSBzYWZlIHNodXRkb3duLCBidXQgdGhhdA0KaW1wbGllcyB0aGF0IHBtIGlzIGRvd24g
YWxyZWFkeSwgc28gYWxsIHlvdSBuZWVkIHRvIGRvIGlzIGEgInJlYm9vdCINCmNvbW1hbmQuICBZ
b3UgZG9uJ3QgbmVlZCB0byBzdGFydCBwbSBhbmQgdGhlbiB1c2UgdGhlIG5meHNoIGNvbW1hbmQu
DQoNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09DQoNCkltcG9ydGFudHM6DQoNCjw8SVRFTT4+DQpQbGVhc2UgcmVt
b3ZlICJ3aGl0ZXNwYWNlIHJ1YmJpc2giIHdoaWNoIGlzIHRoZSBpbXBvbGl0ZSBjb2xsZWN0aXZl
DQp0ZXJtIGZvciB0cmFpbGluZyB3aGl0ZSBzcGFjZSwgYmxhbmsgbGluZXMgd2l0aCB3aGl0ZSBz
cGFjZSwgYW5kDQpzcGFjZXMgY292ZXJlZCBieSB0YWJzLg0KDQo8PElURU0+Pg0KQSBnb29kIGNv
bnZlbnRpb24gdG8gdXNlIGlzIHRvIHBhcmFtZXRlcml6ZSBjb21tb24gc3ViLXBhdGhzLiAgRm9y
DQpleGFtcGxlOg0KDQpPX1BBVEg9L3Vzci9sb2NhbC9hZ2lsZQ0KT0NfUEFUSD0iJHtPX1BBVEh9
L2NvbmYiDQoNCkZPT0ZfRklMRT0iJHtPQ19QQVRIfS9mb29mLmNvbmYiDQoNCnJhdGhlciB0aGFu
DQoNCkZPT0ZfRklMRT0vdXNyL2xvY2FsL2FnaWxlL2NvbmYvZm9vZi5jb25mDQoNCiR7T19QQVRI
fS9iaW4vcG0NCg0KcmF0aGVyIHRoYW4NCg0KL3Vzci9sb2NhbC9hZ2lsZS9iaW4vcG0NCg0KPDxJ
VEVNPj4NClBsRWFTZSBjaG9vc2UgYSB2YXJpYWJsZSBjb252ZW50aW9uIGFuZCBzdGljayB0byBp
dC4gIFNvbWUgdmFyaWFibGUgbmFtZXMNCmFyZSBtaXhlZCB1cHBlciBhbmQgbG93ZXIgY2FzZSwg
c29tZSBhcmUgYWxsIHVwcGVyLCBzb21lIGFyZSBhbGwgbG93ZXIuDQpUaGUgbWl4ZWQgY2FzZSBp
cyB0aGUgd29yc3QsIElNTy4gIFlvdSBtYXkgd2lzaCB0byBhZG9wdCBhIGNvbnZlbnRpb24NCndo
ZXJlIGxvY2FsIHZhcmlhYmxlcyBhcmUgYWxsIGxvd2VyLCBhbmQgZ2xvYmFsIHZhcmlhYmxlcyBh
cmUgYWxsIHVwcGVyLA0Kb3Igc29tZXRoaW5nIGxpa2UgdGhhdC4gIEJ1dCBjdXJyZW50bHkgdGhl
cmUgaXMgbm8gY29uc2lzdGVudCBjb252ZW50aW9uLA0KYW5kIG1peGVkIGNhc2Ugc2hvdWxkIG5v
dCBiZSB1c2VkIGF0IGFsbC4NCg0KPDxJVEVNPj4NClBsZWFzZSB0ZW5kIHRvIHRoZSBjb21tZW50
cy4gIFNvbWUgcGFydHMgb2YgdGhlIHNoZWxsIHNjcmlwdCBhcmUNCmRldm9pZCBvZiBjb21tZW50
cywgd2hpbGUgb3RoZXIgcGFydHMgaGF2ZSBzb21lIGNvbW1lbnRzIHdpdGgNCmNvbmZ1c2luZyB0
eXBvcywgZ3JhbW1lci1vJ3MsIGV0Yy4gIEl0J3MgcmVhbGx5IGhhcmQgdG8gbWFpbnRhaW4gYQ0K
c2hlbGwgc2NyaXB0IHdpdGhvdXQgc3VmZmljaWVudCBjb21tZW50aW5nLiAgQnkgc3VmZmljaWVu
dCBJIGRvbid0DQptZWFuIHF1YW50aXR5LCBJIG1lYW4gc3VmZmljaWVudCB0byBtYWtlIHRoZSBj
b2RlIGVhc3kgdG8gcmVhZCBhbmQNCmZvbGxvdyBhbmQgbW9kaWZ5LiAgVHdvIG1vbnRocyBmcm9t
IG5vdyB3aGVuIHlvdSBuZWVkIHRvIGZpeCBhIGJ1ZyBpbg0KdGhpcywgeW91IHdpbGwgdGhhbmsg
eW91cnNlbGYgZm9yIGFkZGluZyBkZWNlbnQgY29tbWVudHMuDQoNCjw8SVRFTT4+DQpQbGVhc2Ug
YWRkIHVzYWdlIG1lc3NhZ2Ugd2hlbiBzY3JpcHQgZXhpdHMgYmVjYXVzZSBvZiBhbiBpbmNvcnJl
Y3QNCmFyZ3VtZW50IG9yIGluc3VmZmljaWVudCBhcmd1bWVudHMsIGV0Yy4gW2xpbmUgODIgYW5k
IG90aGVyc10NCg0KPDxJVEVNPj4NClNvbWUgZnVuY3Rpb25zIGhhdmUgaW5jb3JyZWN0IGluZGVu
dGluZywgbGlrZSBjZF9mbGFzaC4NCg0KPDxJVEVNPj4NClRoZSB5ZWFyIGlzIDIwMDcuICBJIGtu
b3cgYmVjYXVzZSBpdCBzYXlzIHNvIGluIHRoZSBkYXRlIGNyZWF0ZWQuICBCdXQNCml0IHNheXMg
Y29weXJpZ2h0IDIwMDYuICBEb2guDQoNCjw8SVRFTT4+DQpNYWtlIHlvdXIgZnV0dXJlIGxpZmUg
ZWFzeSB3aGlsZSByZWR1Y2luZyB0aGUgc2NyaXB0J3MgZmlsZSBzaXplOg0KcmVwbGFjZSBpbnN0
YW5jZXMgb2YNCg0KZWNobyAiZm9vIiB8IHRlZSAtYSAkbG9nDQoNCndpdGggYSBmdW5jdGlvbiBs
aWtlDQoNCm9zX2xvZygpDQp7DQoJaWYgWyAiJE5PX0xPR19NT0RFIiBdIDsgdGhlbg0KCQl0ZWVf
Y21kPSIiDQoJZWxzZQ0KCQl0ZWVfY21kPSIgfCB0ZWUgLWEgJGxvZyINCglmaQ0KDQoJZXZhbCBl
Y2hvICIkQCIgJHRlZV9jbWQNCn0NCg0Kb3NfbG9nICJmb28iDQoNClRoYXQgd2F5IHlvdSBjYW4g
Y2hhbmdlIGl0IGxhdGVyIHRvIHVzZSBwcmludGYgb3Igc29tZSBvdGhlciBzbGljaw0KaW5ub3Zh
dGlvbnMsIGxpa2UgbG9nIGxldmVscywgZXRjLg0KDQo8PElURU0+Pg0KVGhlICctbicgb3B0aW9u
IHRvIHRoZSB0ZXN0IGNvbW1hbmQgaXMgaW1wbGllZCwgYW5kIGl0IGlzIHVzdWFsbHkgbW9yZQ0K
cmVhZGFibGUgdG8ganVzdCBsZWF2ZSBpdCBvdXQuICBUaGluZ3MgbGlrZQ0KDQppZiBbIC1uICIk
RkxBR19WQVIiIF0gOyB0aGVuDQoJb3NfbG9nICJmYXJ0Ig0KZmkNCg0KYXJlIGJldHRlciB3cml0
dGVuIGFzDQoNCmlmIFsgIiRGTEFHX1ZBUiIgXSA7IHRoZW4NCg0Kc28gaXQgcmVhZHMgYWxtb3N0
IGxpa2UgQyBjb2RlLg0KDQo8PElURU0+Pg0KQmUgY2FyZWZ1bCBub3QgdG8gdXNlICJybSAtZiIs
ICJtdiAtZiIsICJjcCAtZiIgd2hlbiB5b3UgYWN0dWFsbHkgd291bGQNCndhbnQgdG8gc2VlIGVy
cm9ycyBmcm9tIHRob3NlIGNvbW1hbmRzLiAgSSdtIGp1c3Qgc2F5aW4nLg0KDQo8PElURU0+Pg0K
ZnVuY3Rpb24gcmVtb3VudF9wcmltYXJ5OiBtYXliZSBhIGJldHRlciBuYW1lIHdvdWxkIGJlDQpt
b3VudF9wcmltYXJ5X3J3IGFuZCBtb3VudF9wcmltYXJ5X3JvDQoNCjw8SVRFTT4+DQpmdW5jdGlv
biByZW1vdmVfb2xkX21hbmlmZXN0OiB0d28gY2QgY29tbWFuZHMgYXQgdGhlIGJlZ2lubmluZywg
b25seQ0KdGhlIHNlY29uZCBvbmUgaXMgbmVjZXNzYXJ5LCBvYnZpb3VzbHkuDQoNCjw8SVRFTT4+
DQpBdm9pZCBjb21tZW50cyBsaWtlDQoNCiMgV2VsbCBpZiB0aGV5IGFyZSBtaXNzaW5nIGxldCdz
IHVwZ3JhZGUgdGhlbS4NCg0KVGhleSB3aG8/ICBUaGV5IHdoYXQ/ICBJIHJlYWxseSBjb3VsZG4n
dCB0ZWxsLg0KDQo8PElURU0+Pg0KUGxlYXNlIGV4cGxpY2l0bHkgdGVzdCB0aGUgTmVlZF9OZXdf
RGV2cyBmdW5jdGlvbmFsaXR5LiAgSXQgbG9va3MgdG8NCm1lIGxpa2UgaXQgd29uJ3Qgd29yaywg
YnV0IEkgY291bGQgYmUgd3JvbmcuICBBZnRlciB5b3UgY2hhbmdlIHRoZQ0KdmFyaWFibGUgbmFt
ZSwgb2YgY291cnNlIH46XikNCg0KPDxJVEVNPj4NCllvdSBkb24ndCBuZWVkIHRvIGRvIGENCg0K
ZWNobyAiIg0KDQphIHNpbXBsZSBlY2hvIHcvbyBhcmd1bWVudHMgZG9lcyB0aGUgc2FtZSB0aGlu
Zy4NCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQojIHZpbTp3bT0xMCB0cz00IHN3PTQNCg==

--MP_p65suaRMBx/hJ.=sM7c7wPr--
