AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071017111753.6a715b07@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9143@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 17 Oct 2007 11:18:51 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review
Message-ID: <20071017111851.4c3b7ea7@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9143@onstor-exch02.onstor.net>
References: <20071016180856.45ad7eb0@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9143@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 17 Oct 2007 11:10:33 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Are you going to be in today? I would like to explain the changes to
> the Makefile. I broke up the one main target into chunks to facilitate
> debugging and the case where a patch fails.
> 
> I can move the patch file from the src directory to the source
> hierarchy. No big thing there.
> 
> Any way it would be good for us to go over these changes in detail
> together and not via email.

I completely agree which is why I cut the comments short.  Also there
were a lot of changes and I figured why go over all this bit-by-bit in
my head and try and figure it out when 10 minutes with Larry will take
care of it.  Unfortunately, it doesn't look good for me coming in today,
even though I originally planned on it.  I had to take a pain pill this
morning and I can't drive after taking one of those howizters.  ~:^(

> Larry 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, October 16, 2007 6:09 PM
> To: Larry Scheer
> Subject: Re: Please review
> 
> On Tue, 16 Oct 2007 17:39:03 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > My workspace is ~larrys/src/dev
> > 
> > Change 25873 by larrys@larrys on 2007/10/16 12:32:38 *pending*
> > 
> >         Makefile updated with rules to patch debian code and update
> > the version in the changelog with an epoch number.
> >         Reviewed by: AndyS
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/Pkgs/source/wget/Makefile#1 edit
> > ... //depot/dev/linux/src/wget-1.10.2/debian/changelog#1 edit
> > ...
> //depot/dev/linux/src/wget-1.10.2/debian/patches/debianrules.patch#1
> > add
> > ...
> //depot/dev/linux/src/wget-1.10.2/debian/patches/onstor-src.dpatch#1
> > add
> 
> linux/Pkgs/source/wget/Makefile
> 
>      wah?  we need to go over this in detail.
> 
> 
> linux/src/wget-1.10.2/debian/changelog
> 
>      looks good
> 
> 
> linux/src/wget-1.10.2/debian/patches/debianrules.patch
> 
>      >>add linux/src/wget-1.10.2/debian/patches/debianrules.patch
> 
>      uh, huh?  linux/src is the wrong directory
> 
> 
> linux/src/wget-1.10.2/debian/patches/onstor-src.dpatch
> 
>      >>add linux/src/wget-1.10.2/debian/patches/onstor-src.dpatch
> 
>      nope, all this stuff needs to go in Source, remember?  we are
>      doing away with src.  we have Pkgs/binary and Pkgs/source, no
>      additional stuff in linux/src.
> 
> 
