AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071018145709.7fe05a2d@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<fbuihuu@gmail.com>,<macro@linux-mips.org>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	1192741953-7040-4-git-send-email-fbuihuu@gmail.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 18 Oct 2007 14:57:23 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Franck Bui-Huu <fbuihuu@gmail.com>
Cc: macro@linux-mips.org
Subject: Re: [PATCH 3/4] vmlinux.ld.S: correctly indent .data section
Message-ID: <20071018145723.4e4153c1@ripper.onstor.net>
In-Reply-To: <1192741953-7040-4-git-send-email-fbuihuu@gmail.com>
References: <1192741953-7040-1-git-send-email-fbuihuu@gmail.com>
	<1192741953-7040-4-git-send-email-fbuihuu@gmail.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 18 Oct 2007 23:12:32 +0200 Franck Bui-Huu <fbuihuu@gmail.com>
wrote:

> Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
> ---
>  arch/mips/kernel/vmlinux.lds.S |   32
> +++++++++++++++++--------------- 1 files changed, 17 insertions(+),
> 15 deletions(-)
>=20
> diff --git a/arch/mips/kernel/vmlinux.lds.S
> b/arch/mips/kernel/vmlinux.lds.S index e0a4dc0..2f6c225 100644
> --- a/arch/mips/kernel/vmlinux.lds.S
> +++ b/arch/mips/kernel/vmlinux.lds.S
> @@ -55,21 +55,23 @@ SECTIONS
> =20
>  	/* writeable */
>  	.data : {	/* Data */
> -	  . =3D . + DATAOFFSET;		/* for
> CONFIG_MAPPED_KERNEL */
> -	  /*
> -	   * This ALIGN is needed as a workaround for a bug a gcc
> bug upto 4.1 which
> -	   * limits the maximum alignment to at most 32kB and
> results in the following
> -	   * warning:
> -	   *
> -	   *  CC      arch/mips/kernel/init_task.o
> -	   * arch/mips/kernel/init_task.c:30: warning: alignment of
> =C3=A2=C2=80=C2=98init_thread_union=C3=A2=C2=80=C2=99
> -	   * is greater than maximum object file alignment.  Using
> 32768
> -	   */
> -	  . =3D ALIGN(_PAGE_SIZE);
> -	  *(.data.init_task)
> -
> -	  DATA_DATA
> -	  CONSTRUCTORS
> +		. =3D . + DATAOFFSET;		/* for
> CONFIG_MAPPED_KERNEL */
> +		/*
> +		 * This ALIGN is needed as a workaround for a bug a
> +		 * gcc bug upto 4.1 which limits the maximum

at least fix the text while you're here: 'a bug a gcc bug'

> +		 * to at most 32kB and results in the following
> +		 * warning:
> +		 *
> +		 *  CC      arch/mips/kernel/init_task.o
> +		 * arch/mips/kernel/init_task.c:30: warning:
> alignment
> +		 * of =C3=A2=C2=80=C2=98init_thread_union=C3=A2=C2=80=C2=99 is greater=
 than maximum

is that utf-8 or something?  probably should remove that.

sorry for the picayunes, but hey as long as you're here changing the
indenting ~:^)


> +		 * object file alignment.  Using 32768
> +		 */
> +		. =3D ALIGN(_PAGE_SIZE);
> +		*(.data.init_task)
> +	=09
> +		DATA_DATA
> +		CONSTRUCTORS
>  	}
>  	_gp =3D . + 0x8000;
>  	.lit8 : {
