AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070116182920.2a4f37a1@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 16 Jan 2007 18:30:03 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: review of cmd_upgrade.c
Message-ID: <20070116183003.54f5fbe6@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary=MP_j8kCirGgoTMRYu.A22Vq_eV

--MP_j8kCirGgoTMRYu.A22Vq_eV
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

4-5 simple things need fixing, otherwise peachy

list attached.

Cheers,

a

--MP_j8kCirGgoTMRYu.A22Vq_eV
Content-Type: text/plain; name=cmd_upgrade.c-review.comments
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=cmd_upgrade.c-review.comments

UmV2aWV3IGNvbW1lbnRzIGZvciBjbWRfdXBncmFkZS5jDQoNCmxpbmUgMTUwDQpZb3UgZG9uJ3Qg
bmVlZCB0aGUgc3RhdGljIHN0cmluZyAnbWFuaWZlc3QnLg0KQWxsIHlvdSBkbyBpcyBjYWxsIHlv
dXIgc2NyaXB0IHdpdGggaXQsIHNvIGl0IGRvZXNuJ3QgbWFrZSBzZW5zZSB0bw0KZXZlbiBoYXZl
IGl0IGluIGNtZF91cGdyYWRlLmMuICBKdXN0IHB1dCB0aGF0IHN0YXRpYyBwYXRoIGluIHRoZQ0K
c2NyaXB0IGFuZCByZW1vdmUgaXQgYXMgYW4gb3B0aW9uLCBvciBhdCBsZWFzdCwgcmVtb3ZlIGl0
IGFzIGFuIG9wdGlvbg0KdGhhdCBjbWRfdXBncmFkZSB1c2VzLg0KDQpsaW5lIDE4NA0KbG9va3Mg
bGlrZSBhbiBvbGQgZnVuY3Rpb24gcHJvdG90eXBlLiAgaSB0aGluayB3ZSBkZWxldGVkIHRoYXQs
IGRpZG4ndA0Kd2U/ICB0aGVuIHdlIGNhbiBkZWxldGUgdGhlIHByb3RvdHlwZSB0b28uDQoNCmxp
bmUgMTcxNQ0KWW91IGFyZSBkb2luZyB0aGUgbWtkYiB0aGluZyB0d2ljZS4gIERlbGV0ZSB0aGUg
c3ByaW50Zi9zeXN0ZW0gb25lLA0KYW5kIGFsc28gYXhlIHRoZSAnY21kJyB2YXJpYWJsZSB0aGF0
IGl0IHVzZXMuDQoNCmxpbmUgMTY5MQ0KSSB0aGluayB5b3UgY2FuIHRvc3MgdGhlIHVwZ3JhZGVf
ZGlyZWN0b3JpZXMoKSBjYWxsLiAgU2luY2UgeW91IGFyZQ0KdXNpbmcgdGFyIHRvIGluc3RhbGwg
dGhpbmdzLCB0aGF0IGlzIG5vIGxvbmdlciBuZWVkZWQuICBJIGNhbid0IHRoaW5rDQpvZiBhIHJl
YXNvbiB3aHkgdGhlIC5kaXN0IGZpbGUgaXMgZXZlbiBuZWVkZWQgYXQgYWxsIGFueW1vcmUuICBU
aGlzIHdhcw0KbmVlZGVkIGJlZm9yZSBiZWNhdXNlIHRoZSB1cGdyYWRlIHByb2dyYW0gZGlkbid0
IGhhdmUgYW55IHdheSBvZiBjcmVhdGluZw0KbmV3bHkgbmVlZGVkIGRpcmVjdG9yaWVzLiAgV2hp
Y2ggaXMgYW5vdGhlciBnb29kIHJlYXNvbiB5b3UgYXJlIHVzaW5nIHRhci4NCg0KUGVyaGFwcyB0
aGUgbXRyZWUgY29tbWFuZCBwcnVuZXMgb2xkIGRpcmVjdG9yaWVzLiAgTWF5YmUgaXQgd291bGRu
J3QNCmJlIHNvIGJhZCB0byBqdXN0IGtlZXAgaXQgZm9yIG5vdyB1bnRpbCB3ZSBjYW4gaW50ZWxs
aWdlbnRseSBwcnVuZSBvbGQNCmRpcmVjdG9yaWVzLiAgSWYgaXQgZG9lcyB0aGF0LiAgQ2hlY2sg
YW5kIG1ha2Ugc3VyZSB0aGF0IGl0IHBydW5lcw0KdW5uZWVkZWQgZGlyZWN0b3JpZXMuDQoNCmxp
bmUgMTc1Nw0KRml4IG5hbWUgb2YgZnVuY3Rpb24gaW4gY29tbWVudHMuICBPbGQgYnVnLiAgRGVs
ZXRlIGNvbW1lbnRlZCBjb2RlIGluDQpmdW5jLg0KDQpsaW5lIDIwNjcNCnVzZSB0aGUgZG9fc3lz
dGVtKCkgbm90IHRoZSBhc3ByaW50Zi4gIGFuZCB5b3UgY2FuIHRvc3MgdGhlIGNtZF9zdHINCnZh
cmlhYmxlLg0KDQpMb29rcyBnb29kLiAgV2F5IHRvIGNob3AgYSBidW5jaCBvZiBjb2RlLg0KDQoN
Cg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0K
IyB2aW06dHM9NCB3bT0xMCBzdz00DQo=

--MP_j8kCirGgoTMRYu.A22Vq_eV--
