AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071023110318.51e3a5ea@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E062ACF44@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 23 Oct 2007 11:03:43 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: please review
Message-ID: <20071023110343.42adbfdd@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E062ACF44@onstor-exch02.onstor.net>
References: <20071023033033.4bff359c@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E062ACF44@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 23 Oct 2007 09:12:00 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Ds1511.c:
> 
> 533, 544-551 - some comment on why you are & the values with some
> constants which are different for each field.

whatever.  sure.  oh, hey, i found and fixed a bug while i was there.

> Ds1511.h: 
> 
> 74: Start the name of the constant with "RTC" or "DS1511" as
> everything else in this file.

typical comment from the product of a communist regime.  i really don't
get, and there hate, why there is two macros for every constant.
wasn't the first set of macros good enough?  it seems every single rtc
driver does this, i just don't get the insanity.  also, the watchdog
macros all have RTC_WD in them, instead of just WD_.  just more insane
communistic nonsense.

but communism is hard to resist.  so i changed it.
 
> Reset.c: 
> 
> 33: Restart immediately instead of waiting 4 seconds?

nah, 4 seconds it is.  that's a lot better than 16 seconds like it used
to be.  you don't want it to be instant, otherwise people will think
something bad happened.  also, you want to give the user a few seconds
to read the output before it gets scrolled off the screen by all the
reset/post messages.

> Setup.c:
> 
> 320: Why remove __init?

beats the hell out of me.  it's there now.
 
> 
> 
> 
> 
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Tuesday, October 23, 2007 3:31 AM
> >To: Maxim Kozlovsky
> >Subject: please review
> >
> >The first 8 files are the real files, the rest are git changes.
> >
> >
> >
> >Change 25993 by andys@ripper on 2007/10/23 02:39:11 *pending*
> >
> >        Fix clock source RTC driver and callers.
> >
> >        Change watchdog API to allow callers to set watchdog to
> arbitrary
> >        times.  Fixes long wait on reboots.
> >
> >        Clean up pd6729 driver debug messages, and get rid of DBE
> > OOPS from pcmcia layers.
> >
> >Affected files ...
> >
> >... //depot/dev/linux/kernel/linux-mips-
> >2.6/arch/mips/onstor/bobcat/ds1511.c#1 edit
> >... //depot/dev/linux/kernel/linux-mips-
> >2.6/arch/mips/onstor/bobcat/ds1511.h#1 edit
> >... //depot/dev/linux/kernel/linux-mips-
> >2.6/arch/mips/onstor/bobcat/platform.c#2 edit
> >... //depot/dev/linux/kernel/linux-mips-
> >2.6/arch/mips/onstor/bobcat/reset.c#1 edit
> >... //depot/dev/linux/kernel/linux-mips-
> >2.6/arch/mips/onstor/bobcat/setup.c#3 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/drivers/ide/ide-disk.c#1
> edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/drivers/pcmcia/pd6729.c#2
> edit
> >... //depot/dev/linux/kernel/linux-mips-
> >2.6/drivers/pcmcia/rsrc_nonstatic.c#2 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/FETCH_HEAD#2 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/HEAD#1 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/ORIG_HEAD#2 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/index#3 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/info/refs#2 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/info/packs#2
> edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >406c14816730814f196d4c27449b79d97aa36519.idx#1 delete
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >406c14816730814f196d4c27449b79d97aa36519.pack#1 delete
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >bb072e7c28b4084ede80da8c8b5153542cf7c887.idx#1 delete
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >bb072e7c28b4084ede80da8c8b5153542cf7c887.pack#1 delete
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.6.16-
> >stable#1 edit
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.6.17-
> >stable#1 edit
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.6.18-
> >stable#1 edit
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.6.19-
> >stable#1 edit
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.6.20-
> >stable#1 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/master#2
> edit
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-2.6.20-
> >stuper-hack#3 delete
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-bc-
> >2.6.20#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-cg-
> >2.6.22-dev#1 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/origin#2
> edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/remotes/origin#2
> >edit ...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.4.33-
> >stable#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.4.34-
> >stable#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.6.21-
> >stable#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.6.22-
> >stable#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/linux-2.6.23-
> >stable#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >pre1#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >pre2#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >pre3#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >pre4#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >pre5#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >pre6#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >rc1#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >rc2#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >rc3#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34-
> >rc4#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34.1#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34.2#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34.3#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34.4#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34.5#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.4.34.6#1
> >add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.45#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.45-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.46#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.46-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.47#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.47-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.48#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.49#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.49-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.50#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.50-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.51#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.51-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.52#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.52-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.53#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.53-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.54#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.54-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.16.55#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.16.55-
> >rc1#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.10#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.11#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.12#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.13#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.14#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.15#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.16#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.17#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.18#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.19#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.20#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.20.21#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.20.4#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.20.5#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.20.6#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.20.7#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.20.8#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.20.9#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.21.1#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.21.2#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.21.3#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.21.4#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.21.5#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.21.6#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.21.7#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.22.1#1
> >add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-
> >2.6.22.10#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.22.2#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.22.3#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.22.4#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.22.5#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.22.6#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.22.7#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.22.8#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.22.9#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.23#1
> >add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.23-
> >rc4#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.23-
> >rc5#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.23-
> >rc7#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.23-
> >rc8#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.23-
> >rc9#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/tags/linux-2.6.23.1#1
> >add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >300e652e0fccfef4973ba05870afb48a8ad192e8.idx#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >300e652e0fccfef4973ba05870afb48a8ad192e8.pack#1 add
