AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070118164121.68b8dbf9@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 18 Jan 2007 16:42:09 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: things changed after my review of cmd_upgrade.c
Message-ID: <20070118164209.5b733e69@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I notice some things were changed after my review.  These should be
fixed:

line 688
this line is mysteriously only indented 3 columns instead of 4.  not
sure how you did that, but it should be 4 or a tab.  and there's no
need for a blank line after.

line 825
get rid of 'rc =', this return value is always overwritten and never
checked.  having it in there implies that it is.

line 1468
i missed this in my original review, i think.  shouldn't be a space
after open paren

line 1617
move 'char *mtree_file)' up to this line if there is room for it in an
80 column window.  if there isn't room, then disregard.

line 1694
please add a comment about how we are copying config files here w/o any
kind of locking or freezing and that they could end up in a completely
inconsistent state and that we are total idiots for doing this.  maybe
someone will be motivated to fix this one day because of the comment.


line 2479
please add a space between 'rc' and '='
i guess i didn't fix the formatting a couple of lines down.  shame on
me.

das it

