AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071105131115.7bab7a87@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E066D13F2@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 5 Nov 2007 13:11:47 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20071105131147.5e304931@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E066D13F2@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E066D13F2@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 5 Nov 2007 11:51:42 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> This should teach you to define prototypes in the include files.
> 
> Change 26219 by maximk@maximk-5 on 2007/11/05 11:39:24 *pending*
> 
>         Use prototype correctly and define it in common place.
> 
>            Define get_stats routine, it can not be null in the new
> kernel.
> 
>            Use correct header in mgmbus_pci_intr().
> 
>            Remove debugging printf.
> 
>            reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/dev/linux/kernel/linux-mips-2.6/bobcat-config#6 edit
> ...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c#
> 4 edit
> ...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h#
> 2 edit
> ... //depot/dev/linux/kernel/linux-mips-2.6/net/neteee/neteee.c#4 edit

Please fix individual files 
drivers/ssc-mgmt-bus/[bc]*.c
to remove their mgmtbus_intr prototypes.



linux/kernel/linux-mips-2.6/bobcat-config

     dang, it looks like i mangled this with my last checkin.  go ahead
     restore its previous value.

linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c

     looks good

linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h

     added mgmtbus_intr prototype

linux/kernel/linux-mips-2.6/net/neteee/neteee.c

     nice grab on the debug printf

