AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071105175748.27260f1a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E066D173C@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 5 Nov 2007 17:57:58 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20071105175758.119ce027@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E066D173C@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E066D173C@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 5 Nov 2007 17:28:51 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Change 26225 by maximk@maximk-5 on 2007/11/05 17:21:45 *pending*
> 
>            Cougar updates for the rcon and mgmt bus drivers.
> 
>            Use the mailbox interrupts for rcon and mgmt bus.
> 
>            Instead of making up the SSC virtual address in the fp and
> txrx code,
>            pass around the PCI offsets which are the same for each CPU
> and
>            let every CPU convert it to its local address as its sees
> fit.
> 
>            Use uint32_t instead of pointers in the shared data
> structures,
>             pointers have different size on cougar.
> 
>            Reviewed by andys.
> 
> Affected files ...
> 
> ...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c#
> 5 edit
> ...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h#
> 3 edit
> ...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/rcon.c#3
> edit

You don't have to change the runtimes for txrx and fp for any of this
to work?  I admit to being very confused by the PCI stuff, but if it
works, it works.

linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c

     line 126

     can you preserve the indenting?

     line 1008-1010

     i'd rather see #elif defined(CONFIG_ONSTOR_COUGAR) because it makes
     it much more readable.  these 4 ifdef blocks should really only
     be two.  or none.  i'd rather see a mgmtbus_init routine in each of
     {bobcat,cougar)_mgmt_bus.c, but I'll make that an optional request.

linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h

     looks ugly, but if it works, it works

linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/rcon.c

     line 36

     save the indenting -- it's a whale!

     line 57

     can't we put all these defines in mgmt_bus.h?  ie., hide them as
     much as possible?  they really give me the creeps.

     line 440-444

     make these elif's as they improve readability a lot, or better
     yet do as mgmt_bus do and put in separate files.  not quite enough
     code to put in separate files.

