AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071108140530.2cea932f@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E06794636@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 8 Nov 2007 14:05:51 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20071108140551.65c9d17b@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E06794636@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E067945DC@onstor-exch02.onstor.net>
	<20071108122602.408ddc56@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E06794636@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 8 Nov 2007 12:32:53 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> I have no idea what ksymoops is, but they should not care, these
> definitions are used only for the core dump and ptrace and debugger
> seems to be working ok.

My word, you don't know what ksymoops is?  Well I never.

But seriously, go ahead and check this one in.  Looks good to me.

> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Thursday, November 08, 2007 12:26 PM
> >To: Maxim Kozlovsky
> >Subject: Re: Please review
> >
> >Have you tested this with things like ksymoops?  I'm concerned that
> >this will break other things.  The change to binfmt_elfo32.c looks
> >right to me, but the other one makes me nervous.
> >
> >On Thu, 8 Nov 2007 11:50:49 -0800 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Change 26264 by maximk@maximk-13 on 2007/11/08 11:43:36 *pending*
> >>
> >>         Fix the core dump on cougar - define ELF_CORE_COPY_REGS
> before
> >>            including elfcore.h.
> >>
> >>            Wrong function was used to copy the registers, causing
> >> incorrect
> >>            core dump and memory corruption.
> >>
> >>            Use core register definitions compatible with our
> >> version of gdb.
> >>
> >>            Reviewed by andys.
> >>
> >> Affected files ...
> >>
> >> ...
> >>
> //depot/dev/linux/kernel/linux-mips-2.6/arch/mips/kernel/binfmt_elfo32.c
> >> #1 edit
> >> ... //depot/dev/linux/kernel/linux-mips-2.6/include/asm-mips/reg.h#1
> >> edit
