AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071109104617.1a56825b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E06794C3D@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 9 Nov 2007 10:46:31 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20071109104631.59b3b828@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E06794C3D@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E06794AE6@onstor-exch02.onstor.net>
	<20071109104100.08d58b69@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E06794C3D@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 9 Nov 2007 10:44:59 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> 
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Friday, November 09, 2007 10:41 AM
> >To: Maxim Kozlovsky
> >Subject: Re: Please review
> >
> >On Fri, 9 Nov 2007 08:46:14 -0800 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Change 26277 by maximk@maximk-13 on 2007/11/09 08:39:17 *pending*
> >>
> >>         Pass the mac address to the embedded cpus on cougar.
> >>            Reviewed by andys.
> >>
> >> Affected files ...
> >>
> >> ...
> >>
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/bobcat_mgmt
> >> _bus.c#3 edit
> >> ...
> >>
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt
> >> _bus.c#3 edit
> >> ...
> >>
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c#
> >> 7 edit
> >> ...
> >>
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h#
> >> 4 edit
> >> ...
> >> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/rcon.c#4
> >> edit
> >> ... //depot/dev/nfx-tree/code/sm-jmptbl/jmptbl.S#1 edit
> >> ... //depot/dev/nfx-tree/code/sm-seep/seep-api.c#4 edit
> >> ... //depot/dev/nfx-tree/code/ssc-mgmt-bus/mgmt-bus.h#2 edit
> >
> >linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/bobcat_mgmt_bus.c
> >
> >     looks good
> >
> >linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt_bus.c
> >
> >     looks good
> >
> >linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c
> >
> >     looks good
> >
> >linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h
> >
> >     looks good
> >
> >linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/rcon.c
> >
> >     looks good
> >
> >nfx-tree/code/sm-jmptbl/jmptbl.S
> >
> >     looks good
> >
> >nfx-tree/code/sm-seep/seep-api.c
> >
> >     i thought you removed support for the gethostid function from
> >     the jmptbl.S file?
> [MK] This removes support for builtin prom function, which did not do
> anything. 
> >
> >nfx-tree/code/ssc-mgmt-bus/mgmt-bus.h
> >
> >     this structure is used in multiple files and defined separatedly
> >     in multiple places.  can we eliminate that?
> >     if there is a list of kernel header files that should be
> "exported"
> >     the nfx-space, let me know what they are and I will take care of
> >     making those mods.
> [MK] Not now. 

OK
