AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E069923BB@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 15 Nov 2007 10:36:48 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20071115103648.2eb92d45@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E069923BB@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E069923BB@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 15 Nov 2007 08:54:45 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Ok added config option
> 
> Change 26335 by maximk@maximk-13 on 2007/11/13 09:35:07 *pending*
> 
>         Do not use fixed mac addresses, they are set in prom now.
> 
>            Add configuration variable to be able to switch using the
> static mac
>            independent of CFE option.
> 
>            Can't read the hardware register because the driver
> temporary writes 0
>            in there, use the variable.
> 
>            Fix the extraction of the mac address bits.
> 
>            Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/dev/linux/kernel/linux-mips-2.6/arch/mips/sibyte/Kconfig#2
> edit
> ... //depot/dev/linux/kernel/linux-mips-2.6/cougar-config#3 edit
> ... //depot/dev/linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c#2
> edit
> ...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt
> _bus.c#4 edit

linux/kernel/linux-mips-2.6/arch/mips/sibyte/Kconfig

     add depends on NET_SB1250_MAC

     and should be in drivers/net/Kconfig, not arch/mips/sibyte/Kconfig

linux/kernel/linux-mips-2.6/cougar-config

     looks good

linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c

     line 339

     do you think we should do this?

     #ifndef CONFIG_ONSTOR_COUGAR
     static
     #endif
     uint64_t sbmac_orig_hwaddr[MAX_UNITS];

linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt_bus.c

     looks good

