AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071115104923.73e03f1e@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E069924AD@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 15 Nov 2007 10:49:29 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20071115104929.234db6e6@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E069924AD@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E069923BB@onstor-exch02.onstor.net>
	<20071115103648.2eb92d45@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E069924AD@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 15 Nov 2007 10:45:39 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> 
> Ok whatever. 
> linux/kernel/linux-mips-2.6/arch/mips/sibyte/Kconfig
> >
> >     add depends on NET_SB1250_MAC
> >
> >     and should be in drivers/net/Kconfig, not
> > arch/mips/sibyte/Kconfig
> >
> >linux/kernel/linux-mips-2.6/cougar-config
> >
> >     looks good
> >
> >linux/kernel/linux-mips-2.6/drivers/net/sb1250-mac.c
> >
> >     line 339
> >
> >     do you think we should do this?
> >
> >     #ifndef CONFIG_ONSTOR_COUGAR
> >     static
> >     #endif
> >     uint64_t sbmac_orig_hwaddr[MAX_UNITS];
> [MK] Does not really matter, does it?

Just asking.

> >linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt_bus.c
> >
> >     looks good
> 
