AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071115184407.76c876d0@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E069927BE@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 15 Nov 2007 18:45:32 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: please Review
Message-ID: <20071115184532.1851f33c@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E069927BE@onstor-exch02.onstor.net>
References: <20071115170855.03e509ae@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E069927BE@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 15 Nov 2007 17:16:51 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Makefile: No, we want to use all the processors and then some to
> compensate for the I/O latencies. If you want better response times
> while running the compilation you can always run make with "nice".

I know all about I/O latencies.  Hey, I don't do this for myself, I do
it for people sharing machines like compile2 and whatnot.  At least
there will be one "processor-lite" *slightly* available for bash
response. Since each compile uses up 2-3 processes, it's going to
hammer on all the processors anyway.

But fine, have it your way.  I remove the "-1" as we speak.

> Sb_wdog.c:
> 
> 320: Why don't you declare the function correctly instead of casting
> it

Because I need a (char *) not a (void *) because I want to add to the
address by the number of bytes, not the number of ... something.
It seemed a waste to allocate a local variable and assign it just to do
that.  And I didn't want to have to do some ifdef SIZEOF_LONG=64 etc
nonsense that would just make the code harder to read.

> 
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Thursday, November 15, 2007 5:09 PM
> >To: Maxim Kozlovsky
> >Subject: please Review
> >
> >Change 26386 by andys@ripper on 2007/11/15 16:38:26 *pending*
> >
> >        Fix some kernel compile warnings.
> >        Adjust build to use all but one of the "processors" of the
> >        machine it is building on.
> >        Update git repository.
> >
> >Affected files ...
> >
> >... //depot/dev/linux/kernel/Makefile#8 edit
> >... //depot/dev/linux/kernel/linux-mips-
> >2.6/arch/mips/onstor/cougar/prom.c#1 edit
> >... //depot/dev/linux/kernel/linux-mips-
> >2.6/arch/mips/onstor/cougar/time.c#1 edit
> >... //depot/dev/linux/kernel/linux-mips-
> >2.6/drivers/char/watchdog/sb_wdog.c#2 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/FETCH_HEAD#4 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/HEAD#3 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/ORIG_HEAD#4 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/index#5 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/info/refs#4 edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/info/packs#4
> edit
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >4cdf6c82560a6bc65d649800c96c85ae53165246.idx#1 delete
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >4cdf6c82560a6bc65d649800c96c85ae53165246.pack#1 delete
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >a7d1fb235b40c0ff63eceb4cd117a535a345c84e.idx#1 add
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/pack/pack-
> >a7d1fb235b40c0ff63eceb4cd117a535a345c84e.pack#1 add
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-2.6.22#1
> >edit
> >...
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-2.6.22-
> >dev#1 branch
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-cg-
> >2.6.22#2 delete
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-cg-
> >2.6.22-dev#3 delete
> >... //depot/dev/linux/kernel/linux-mips-2.6/.git/remotes/origin#4
> >edit
> 
