AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071210114946.066f113b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C91F6@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 10 Dec 2007 11:50:34 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review Change 26643
Message-ID: <20071210115034.245648bc@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C91F6@onstor-exch02.onstor.net>
References: <20071130161032.26d06a01@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C91F6@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


> File: Includes/nfx-defs.h
> Lines 280 -294 are deleted instead of modified is this correct?
> Same with versions of this files that are in the prom directory 

Yes, these definitions, while they would have been handy, were not
actually being used anywhere, so they are gone.  Helps eliminate a
small amount of confusion.

> File Makefile.ssc
> Line 114 you changed the variable name to ONSTOR_DIR from AGILE_DIR
> but did not change the references to AGILE_DIR to ONSTOR_DIR

Fixed.

> File: nfx-tree/code/sm-ea/ea-cfgd.c
> Line 86: using /var/onstor where other areas you replaced this
> directory with /var/log/onstor.

Yeah, trace file files in /var/onstor.  Until this idea gets trampled
by 1000 angry reviewers.

> File code/samba-3.21a/Makefile
> Line 95: You changed VARDIR to /var/log/onstor/samba from
> /var/agile/samba. This means you need to change

Uh, did you forget something here?  Or did you mean the two files
below?  Because they seem to be part of a different comment so I'm not
sure.

> File: sm-fs/fsdb-read-block.c; ssc-authen-lib/authen-lib.c and others 
> Looks like this needs to be sync'd resolved before you submit it.

Everything should be sync'd resolved now.

Thanks,

a


On Tue, 4 Dec 2007 12:43:09 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I mentioned this before, not sure how clearly I expressed it though...
> Looks like you are placing trace files in /var/onstor why not just
> place them in /var/log/onstor well or just place everythin
> in /var/onstor which is a logical replacement for /var/agile. I think
> it would be less confusing for customers and SEs. Check files in
> code/ssc-ncm and code/ssc-ndmp 

I'm gonna go with my plan for splitting up /var/agile
into /var/log/onstor and /var/onstor for now.  We'll see how long that
plan survives design review.

> File code/ssc-nfxsh/verify_install.sh: There were no changes made to
> this file. Looks like it could use some, but thought also needs to be
> given to how and what. 

Gonna hold off on that pending final decision to obsolete system
upgrade in favor of upgrade script.

> File code/ssc-pm/rc.agile lines 81-82: Still have rc.agile in the
> command that is being executed but this file will be named rc.onstor
> when all is done.

IIRC, I have changes for rc.agile which first have to be checked in,
then I have to do a 'rename', so that actually has to be two checkins.

> File openbsd/src/etc/rc.local lines 52-53: Runs rc.agile you probably
> want rc.onstor here correct?

Fixed.

> -----Original Message-----
> From: Andy Sharp 
> Sent: Friday, November 30, 2007 4:11 PM
> To: Larry Scheer
> Subject: please review Change 26643
> 
> change all /usr/local/agile strings to /onstor
> 
> change /var/agile to /var/onstor and /var/log/onstor
> 
> change a couple of files, rc.agile and welcome.agile to rc.onstor and
> welcome.onstor.  the former will have to be done in a second checkin,
> because it has changes that have to be committed first.
> 
> no changes in krb5-whatever and openldap-whatever, there may be
> breakage there, which we'll have to figure out and fix.
> 
> changes won't be checked in before monday
> 
> 
> 
> 
> Change 26643 by andys@ripper on 2007/11/29 15:31:02 *pending*
> 
>         AGILE training day.
> 
> Affected files ...
> 
> ... //depot/dev/descr#1 edit
> ... //depot/dev/descr-bc#1 edit
> ... //depot/dev/make-patch.sh#1 edit
> ... //depot/dev/nfx-tree/Includes/nfx-defs.h#7 edit
> ... //depot/dev/nfx-tree/Makefile#3 edit
> ... //depot/dev/nfx-tree/Makefile.ssc#7 edit
> ... //depot/dev/nfx-tree/Tools/defs.mk#8 edit
> ... //depot/dev/nfx-tree/code/samba-3.21a/Makefile#2 edit
> ... //depot/dev/nfx-tree/code/samba-3.21a/passdb/secrets.c#5 edit
> ... //depot/dev/nfx-tree/code/sendmail/sendmail/main.c#1 edit
> ... //depot/dev/nfx-tree/code/sendmail/sendmail/queue.c#1 edit
> ...
> //depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/asiFibreChan
> nel.c#3 edit
> ...
> //depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsProduct.c
> #3 edit
> ... //depot/dev/nfx-tree/code/sm-bsd-snmpd/linux.h#2 edit
> ... //depot/dev/nfx-tree/code/sm-bsd-snmpd/openbsd.h#2 edit
> ... //depot/dev/nfx-tree/code/sm-ea/ea-cfgd-rx.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-ea/ea-cfgd.c#6 edit
> ... //depot/dev/nfx-tree/code/sm-elog/elog-api.h#2 edit
> ... //depot/dev/nfx-tree/code/sm-event/emrs-api.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-event/event-as-openbsd.c#1 edit
> ... //depot/dev/nfx-tree/code/sm-event/event-as.c#9 edit
> ... //depot/dev/nfx-tree/code/sm-event/openbsd.h#1 edit
> ... //depot/dev/nfx-tree/code/sm-evm/evm-cfgd.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-shell.c#22 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fsdb-read-block.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-fs/restore/restore.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/sanm_test.c#2 edit
> ... //depot/dev/nfx-tree/code/sm-fs/snapadmin#1 edit
> ... //depot/dev/nfx-tree/code/sm-ndmp/nscadmin#1 edit
> ... //depot/dev/nfx-tree/code/sm-opt/fs-linux.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-opt/fs-openbsd.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-opt/opt-api.h#4 edit
> ... //depot/dev/nfx-tree/code/sm-sct/sct-ccc-ssl.c#5 edit
> ... //depot/dev/nfx-tree/code/sm-sct/sct-http.c#5 edit
> ... //depot/dev/nfx-tree/code/sm-sct/sct.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-sct/taskmgr.c#6 edit
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-conf.h#1 edit
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-devcap#3 edit
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-init-devcap.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-main.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-sdm/storage.c#5 edit
> ... //depot/dev/nfx-tree/code/sm-test/how-to-garfield#1 edit
> ... //depot/dev/nfx-tree/code/ssc-authen-lib/authen-lib-api.h#3 edit
> ... //depot/dev/nfx-tree/code/ssc-authen-lib/authen-lib.c#8 edit
> ...
> //depot/dev/nfx-tree/code/ssc-authen-lib/authen-localaccounts-api.h#2
> edit
> ... //depot/dev/nfx-tree/code/ssc-authen-lib/cifs-map-cfg.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-authentication/auth-cifs.c#8 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/clusdb-tools.c#6 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-api.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#11 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-server.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-test.c#8 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.h#3 edit
> ... //depot/dev/nfx-tree/code/ssc-elog/elog.c#5 edit
> ... //depot/dev/nfx-tree/code/ssc-ncm/ncm.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-ncm/ncm.h#4 edit
> ... //depot/dev/nfx-tree/code/ssc-ndmp/ndmp-main.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-ndmp/ndmp-ssc.h#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxnis/nfxnis-loc.h#1 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#5 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_admin.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#5 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_disk.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#6 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#5 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#12 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_help.c#14 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_ndmp.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_port.c#6 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#5 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_rcon.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sanm.c#5 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_scsi.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysHealth.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysdvt.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#5 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#26 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#12 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#5 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/selecttz#1 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/test/nfxsh-priv-test.c#2 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#1 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_main.c#8 edit
> ... //depot/dev/nfx-tree/code/ssc-openafs-ubik/beacon.c#8 edit
> ... //depot/dev/nfx-tree/code/ssc-openafs-ubik/recovery.c#5 edit
> ... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.h#3 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pm-mcp.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pm.c#9 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.all.linux#1 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.all.openbsd#1 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.init.linux#1 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.init.openbsd#1 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.linux#2 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.openbsd#1 edit
> ... //depot/dev/nfx-tree/code/ssc-pm/rc.agile#5 edit
> ... //depot/dev/nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-rmc/rmc_util.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-sanm/sanm-private.h#1 edit
> ... //depot/dev/nfx-tree/code/ssc-support/cpucrash.sh#1 edit
> ... //depot/dev/nfx-tree/code/ssc-support/emrscron#7 edit
> ... //depot/dev/nfx-tree/code/ssc-support/replay_nfs_show_all.sh#1
> edit ... //depot/dev/nfx-tree/code/ssc-support/support.sh#7 edit
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/timekeep-api.h#4 edit
> ... //depot/dev/nfx-tree/code/ssc-vsd/vs-daemon.c#20 edit
> ... //depot/dev/nfx-tree/extra/strip.sh#1 edit
> ... //depot/dev/nfx-tree/test/lib/ONStor/Expect/GW/fscmd.pm#2 edit
> ... //depot/dev/nfx-tree/test/lib/ONStor/Expect/Ssh.pm#5 edit
> ... //depot/dev/nfx-tree/test/runtests#3 edit
> ...
> //depot/dev/nfx-tree/test/t/all/features/filesystem/stress/StressTest/Ga
> tewayMonitor.pm#1 edit
> ... //depot/dev/openbsd/src/etc/Makefile#4 edit
> ... //depot/dev/openbsd/src/etc/crontab#1 edit
> ... //depot/dev/openbsd/src/etc/flash_install.sh#1 delete
> ... //depot/dev/openbsd/src/etc/inetd.conf#1 edit
> ... //depot/dev/openbsd/src/etc/master.passwd#1 edit
> ... //depot/dev/openbsd/src/etc/master.passwd.org#1 edit
> ... //depot/dev/openbsd/src/etc/mtree/4.4BSD.dist#2 edit
> ... //depot/dev/openbsd/src/etc/newsyslog.conf#1 edit
> ... //depot/dev/openbsd/src/etc/rc#4 edit
> ... //depot/dev/openbsd/src/etc/rc.initial#4 edit
> ... //depot/dev/openbsd/src/etc/rc.local#1 edit
> ... //depot/dev/openbsd/src/etc/rc.shutdown#1 edit
> ... //depot/dev/openbsd/src/etc/root/dot.cshrc#1 edit
> ... //depot/dev/openbsd/src/etc/root/dot.profile#1 edit
> ... //depot/dev/openbsd/src/etc/syslog.conf#1 edit
> ... //depot/dev/openbsd/src/etc/welcome.agile#1 delete
> ... //depot/dev/openbsd/src/etc/welcome.onstor#1 branch
> ... //depot/dev/openbsd/src/krb5-1.4.2/src/Makefile#1 edit
> ... //depot/dev/openbsd/src/libexec/ld.so_elf/ld.so/library.c#1 edit
> ...
> //depot/dev/openbsd/src/usr.sbin/dhcp/dhclient/scripts/dhclient-script#7
> edit
> ... //depot/dev/prom/bc/Includes/nfx-defs.h#1 edit
> ... //depot/dev/prom/cg/Includes/nfx-defs.h#1 edit
> ... //depot/dev/prom/ch/Includes/nfx-defs.h#1 edit
> 
