AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071213155916.7e1d0041@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C921A@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 13 Dec 2007 15:59:50 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Review of 26643
Message-ID: <20071213155950.7766fa5b@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C921A@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C921A@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 12 Dec 2007 19:03:24 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> File: linux/rootfs/Makefile line: 142, and 251-254 I thought we were
> going to keep the link /usr/local/agile --> /onstor  Are you sure you
> want to permanently remove it? At one time we talked about keeping
> this just to prevent breakage in case something was missed.

That was long ago when the directories were changed.  The whole point
of this step is to rid ourselves of it.

> File: nfx-tree/Tools/cw_install.in lines: 442, 536, 835,  still have
> /usr/local/agile

Yes, because the point of the tool is to upgrade from systems that
have the old directory layout.
 
> File: nfx-tree/Tools/defs.mk line: 601 Leaving AGILE_IMAGES_DIR macro
> name but changing it value. If you change this macro name you also
> need to find all uses of it and change the references.

Fixed.

> File: nfx-tree/Tools/flash_install.sh: lines 333-364, 382-390 & 399
> Commented out - why not just remove them?

That's done in the cougar mods that come after this.

> File: nfx-tree/code/ssc-nfxsh/verify-install.sh - You didn't change
> this file in any meaningful way. Perhaps you want to revert it? I
> can  make the changes since I will be working on system upgrade next.

That's what I think will be best, because I didn't feel like I was able
to easily follow the logic, and so was too likely to break it.

> Just a comment... Someone will probably need to address this, someday;
> you changed the name "agile" in the elog to "onstor." For instance:
> "Error sending onstor msg to eventd." I bet eventually Marketing or
> one of our OEMs will want that name changed to the OEM's name. I bet
> the OEM didn't grouse about it previously because the word agile is a
> valid English word and probably wasn't recognized for what it is.

Uh, this most likely a mistake on my part.  Do you remember what file(s)
you saw that in?

> Larry
