AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071214182639.5f38662a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>,<randavar@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E07201306@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 14 Dec 2007 18:26:55 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Cc: "Ramesh R A. Andavar" <randavar@onstor.com>
Subject: Re: PERFORCE change 26965 for review
Message-ID: <20071214182655.19d13006@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E07201306@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E072012BE@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E072012F3@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E07201306@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 14 Dec 2007 17:16:48 -0800 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> You code is:
>   ln -s /etc/localtime /usr/share/zoneinfo/US/Pacific
> 
> Is the direction of the link correct?

That would be "no" ~:^)

> 
> > -----Original Message-----
> > From: Ramesh R A. Andavar
> > Sent: Friday, December 14, 2007 5:08 PM
> > To: Ed Kwan; Andy Sharp
> > Subject: RE: PERFORCE change 26965 for review
> > 
> > 
> > I have Changed the code to use test -r. Please review it again.
> > 
> > Regards
> > Ramesh
> > 
> > -----Original Message-----
> > From: Ed Kwan
> > Sent: Friday, December 14, 2007 4:47 PM
> > To: Ramesh R A. Andavar; Andy Sharp
> > Subject: RE: PERFORCE change 26965 for review
> > 
> > Instead of using dd to see if the file exists, will "test -r" do the
> > trick?
> > 
> > > -----Original Message-----
> > > From: Ramesh R A. Andavar
> > > Sent: Friday, December 14, 2007 3:44 PM
> > > To: Ed Kwan; Andy Sharp
> > > Subject: RE: PERFORCE change 26965 for review
> > >
> > > Hi Ed/Andy,
> > >
> > > I have changed the code to check whether /etc/localtime points to
> > > an invalid file.
> > >
> > > Please review my code and let me know your comments
> > >
> > > My P4 client is ramesh_DEV
> > >
> > > Regards
> > > Ramesh.
> > >
> > > -----Original Message-----
> > > From: Ed Kwan
> > > Sent: Friday, December 14, 2007 1:27 PM
> > > To: Andy Sharp; Ramesh R A. Andavar
> > > Subject: RE: PERFORCE change 26965 for review
> > >
> > > Interesting point.
> > >
> > > > -----Original Message-----
> > > > From: Andy Sharp
> > > > Sent: Friday, December 14, 2007 11:34 AM
> > > > To: ramesh
> > > > Cc: Ed Kwan
> > > > Subject: Re: PERFORCE change 26965 for review
> > > >
> > > > On 14 Dec 2007 11:06:55 -0800 ramesh <ramesh@build-k2-depot>
> wrote:
> > > >
> > > > > Change 26965 by ramesh@ramesh_DEV on 2007/12/14 10:59:41
> > > > >
> > > > > 	On upgrade the time zone is reset to PST.  Modified
> > > > > the upgrade script to skip the /etc/localtime.  TED00020604.
> > > > >
> > > > > 	Reviewed by Ed Kwan
> > > > >
> > > > > Affected files ...
> > > > >
> > > > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#2
> > > > > edit
> > > > >
> > > > >
> > > > > http://liszt:1818/@md=d&cd=//depot/$c=G35@/26965?ac=10
> > > >
> > > > Hi guys,
> > > >
> > > > This change is not sufficient.  If you want to do this, more
> > > > logic
> has
> > > > to be added, because the timezone files might change on an
> upgrade,
> > > > leaving /etc/localtime pointing to nothing.  So you can skip it
> here,
> > > > but after the upgrade is over, you have to check to see if it
> still
> > > > points to something, and if it doesn't, reset it to PST.
