AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071217095314.77fec3ae@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<tim.gardner@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAILOSlScIjCXwWl0000696c@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 17 Dec 2007 09:53:44 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: timg <tim.gardner@onstor.com>
Subject: Re: PERFORCE change 26990 for review
Message-ID: <20071217095344.4691b8d6@ripper.onstor.net>
In-Reply-To: <WEBMAILOSlScIjCXwWl0000696c@mail.onstor.com>
References: <WEBMAILOSlScIjCXwWl0000696c@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On 15 Dec 2007 17:56:56 -0800 timg <tim.gardner@onstor.com> wrote:

> Change 26990 by timg@timg-work on 2007/12/15 17:45:03
> 
> 	Fix for defect 21495.
> 	Reset tick counter each time a block transfer completes to
> prevent mirror stall handling code from activating prematurely.
> 	Prior to this change, if the transfer of the entire chunk of
> extents did not complete within the 6 minute window, it was
> considered a stall and the mirror connection was closed and reopened.
> This was wrong. It should only be considered a stall if no data has
> been transfered in the last 6 minutes.
> 	
> 	Change log level of messages output when aborting a mirror.
> 	Messages not output at err_s.
> 	
> 	reviewed by mikel
> 	regression: dmip over slow link
> 
> Affected files ...
> 
> ... //depot/R3_1_0_DMIP/nfx-tree/code/sm-sanm-agent/sanm-agent-msg.c#9
> edit ... //depot/R3_1_0_DMIP/nfx-tree/code/sm-sanm-agent/sanm-dmip-funcs.c#6
> edit ... //depot/dev/nfx-tree/code/sm-sanm-agent/sanm-agent-msg.c#11
> edit ... //depot/dev/nfx-tree/code/sm-sanm-agent/sanm-dmip-funcs.c#10
> edit

Please do not change two branches with one changelist.  A single
checkin should be atomic, but is not when applied to two branches at
once (think about the operation to back it out of just one branch, or
to integrate it to another branch).  Make it to one branch and
integrate it to others as necessary.

Thanks,

a
