AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071219115712.60ff5a8a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E072E0659@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 19 Dec 2007 11:57:35 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: review cl#27051
Message-ID: <20071219115735.75b53120@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E072E0659@onstor-exch02.onstor.net>
References: <20071218155128.1af30098@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E072E057F@onstor-exch02.onstor.net>
	<20071219114623.1cd93b72@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E072E0659@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 19 Dec 2007 11:47:33 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> I mean if it is not aligned there is the code which reads the last
> byte, you need to flush the cache for the last byte as well.

Let me put it another way, at this level, buflen is always 512 when we
get here from the paging subsystem, so this will always flush the right
amount, as long as you agree that "the right amount" might be too much.
If we get here from any other path, we don't care, and would really
rather not do the flushing, but, well, it ain't great, I know.

> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Wednesday, December 19, 2007 11:46 AM
> >To: Maxim Kozlovsky
> >Subject: Re: review cl#27051
> >
> >On Wed, 19 Dec 2007 10:20:40 -0800 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Libata-core.c:
> >>
> >> This looks like completely wrong place to do cache flush. The cache
> is
> >> not flushed for the remaining byte for some reason.
> >
> >No this is not the best, but it is a work around.  If you have a
> >better place to flush, please let us all in on it.
> >
> >What do you mean "the remaining byte"?
> >
> >>
> >> >-----Original Message-----
> >> >From: Andy Sharp
> >> >Sent: Tuesday, December 18, 2007 3:51 PM
> >> >To: Maxim Kozlovsky
> >> >Subject: review cl#27051
> >> >
> >> >Change 27051 by andys@ripper on 2007/12/18 13:57:40 *pending*
> >> >
> >> >        Changes to make CF cards pageable and bootable.
> >> >        Fix minor whitespace problem in cougar/prom.c.
> >> >        Add 1125 to list of processors to check for proper
> >> >        revision setting in config file.
> >> >
> >> >Affected files ...
> >> >
> >> >... //depot/dev/linux/kernel/linux-mips-
> >> >2.6/arch/mips/onstor/cougar/prom.c#2 edit
> >> >... //depot/dev/linux/kernel/linux-mips-
> >> >2.6/arch/mips/sibyte/sb1250/setup.c#2 edit
> >> >... //depot/dev/linux/kernel/linux-mips-2.6/cougar-config#4 edit
> >> >...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ata/libata-core.c#2
> >> >edit
> >>
