AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071219173333.58ac0f4b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>,<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9243@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 19 Dec 2007 17:33:39 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Cc: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: code review
Message-ID: <20071219173339.33570a2f@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9243@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E03B1BFB2@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9243@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 19 Dec 2007 16:57:49 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Just a suggestion not sure if it is desirable in this case...
> File: ssc-nfxsh/cmd_flash-linux.c lines: 374-377 replace the
> system(command) with do_system() ? - up to you --
> 
> Andy wants to look at these changes since he, too, is interested in
> these changes. So I am copying him.
> 
> Larry
> _____________________________________________
> From: Rendell Fong 
> Sent: Thursday, December 13, 2007 11:29 AM
> To: Larry Scheer
> Subject: code review
> 
> Larry,
> 
> Can you review these changes.  I'd like to check them in to
> consolidate the multiple sys config file lists currently defined as
> well as some things that need fixing for linux.

I'd prefer that you wait until cl#26643 goes in, as these file lists get
changed by that.  It will be much easier to merge your change on top
of that than the other way around.  I think.

As for things that need fixing for linux, please submit those as (a)
separate change list?  Ie, try not to do two different things in one
change.

Question: have you tested these changes?  I mean, have you tried a
'system upgrade', a 'system config reset' and a 'system copy config' at
the very least?  I'm sure you have.

Also, there are several shell scripts that would be included in this
list of files that contain config file lists.  If you're going to
attempt to handle that, I would prefer that all that go in in one
change, or near simultaneous changes.

> Rendell
> 
> 
> 
> Change: 26788
> 
> Client: rendellf
> User:   rendellf
> Description:
>     Update search path for mount/umount, fix mount options, re-enable
> handling
>     of snmp config files, and resetting of passwd/shadow files for
> Linux.
> 
> Files:
>     //depot/dev/nfx-tree/code/sm-opt/cfg_files.h    # add
>     //depot/dev/nfx-tree/code/sm-opt/fs-linux.c # edit
>     //depot/dev/nfx-tree/code/sm-opt/fs-openbsd.c   # edit
>     //depot/dev/nfx-tree/code/sm-opt/fs.c   # edit
>     //depot/dev/nfx-tree/code/sm-opt/linux.h    # edit
>     //depot/dev/nfx-tree/code/sm-opt/openbsd.h  # edit
>     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c   # edit
>     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c # edit
>     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c   # edit
