AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071220163651.5b863dfb@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9250@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 20 Dec 2007 16:37:12 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: review of 26643 again
Message-ID: <20071220163712.473d3bed@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9250@onstor-exch02.onstor.net>
References: <20071218183329.26da962a@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9250@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 20 Dec 2007 16:31:29 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I am just reviewing the Makefiles and 4.4.BSD.dist files and a few
> other things.
> 
>  
> 
> File nfx-tree/Makefile: 
> 
> lines 103-111 (original file 103-105 your file) the ifeq ($(OS) ...)
> logic needs to be put back for SUMCMD, our BSD system doesn't have
> md5sum.

but they both have cksum, so that is what's used for both, unless
that's got some problem i don't know about

> Setting the values of RELBOM and CURBOM can be done outside the
> conditional code.
> 
> Remove lines 780 and 781

You mean remove just the comment, right?  Not the

cd ${PATH_TO_RELEASE}/onstor/lib && \

>  
> 
> File sm-appids/onstor.apps:
> 
>       Lines 3 & 5: change the Name and RCS ID

That has to wait for a second checkin.  I'll do that when I change the
name of rc.agile to rc.onstor.

> 
>  
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, December 18, 2007 6:33 PM
> To: Larry Scheer
> Subject: review of 26643 again
> 
>  
> 
> The changes you need to concentrate on are the changes in
> 
> nfx-tree/Makefile*, especially the target openbsd-rootfs in
> 
> nfx-tree/Makefile.  And the changes to
> 
> openbsd/src/etc/mtree/4.4BSD.dist.
> 
>  
> 
>  
> 
> Change 26643 by andys@ripper on 2007/11/29 15:31:02 *pending*
> 
>  
> 
>         AGILE training day.
> 
>  
> 
> Affected files ...
> 
>  
> 
> ... //depot/dev/descr#1 edit
> 
> ... //depot/dev/descr-bc#1 edit
> 
> ... //depot/dev/linux/rootfs/Makefile#14 edit
> 
> ... //depot/dev/linux/rootfs/etc/inetd.conf#1 edit
> 
> ... //depot/dev/linux/rootfs/etc/init.d/onstor#3 edit
> 
> ... //depot/dev/linux/rootfs/etc/init.d/onstor-config#1 edit
> 
> ... //depot/dev/linux/rootfs/etc/onstor/initial-config#4 edit
> 
> ... //depot/dev/linux/rootfs/etc/passwd#1 edit
> 
> ... //depot/dev/linux/src/krb5-1.4.4/build/sedstatus.sh#1 edit
> 
> ... //depot/dev/make-patch.sh#1 edit
> 
> ... //depot/dev/nfx-tree/Includes/nfx-defs.h#8 edit
> 
> ... //depot/dev/nfx-tree/Makefile#5 edit
> 
> ... //depot/dev/nfx-tree/Makefile.fc#3 edit
> 
> ... //depot/dev/nfx-tree/Makefile.fp#3 edit
> 
> ... //depot/dev/nfx-tree/Makefile.ssc#7 edit
> 
> ... //depot/dev/nfx-tree/Makefile.txrx#2 edit
> 
> ... //depot/dev/nfx-tree/Tools/cw_install.in#7 edit
> 
> ... //depot/dev/nfx-tree/Tools/defs.mk#9 edit
> 
> ... //depot/dev/nfx-tree/Tools/flash_install.sh#2 edit
> 
> ... //depot/dev/nfx-tree/Tools/suffix.mk#5 edit
> 
> ... //depot/dev/nfx-tree/code/samba-3.21a/Makefile#2 edit
> 
> ... //depot/dev/nfx-tree/code/samba-3.21a/passdb/secrets.c#5 edit
> 
> ... //depot/dev/nfx-tree/code/sendmail/sendmail/main.c#1 edit
> 
> ... //depot/dev/nfx-tree/code/sendmail/sendmail/queue.c#1 edit
> 
> ... //depot/dev/nfx-tree/code/sm-appids/Makefile#1 edit
> 
> ... //depot/dev/nfx-tree/code/sm-appids/agile.apps#1 delete
> 
> ... //depot/dev/nfx-tree/code/sm-appids/mkappids#1 edit
> 
> ... //depot/dev/nfx-tree/code/sm-appids/onstor.apps#1 branch
> 
> ...
> //depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/asiFibreChan
> nel.c#3 edit
> 
> ...
> //depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/agile/onsProduct.c
> #4 edit
> 
> ... //depot/dev/nfx-tree/code/sm-bsd-snmpd/linux.h#2 edit
> 
> ... //depot/dev/nfx-tree/code/sm-bsd-snmpd/openbsd.h#2 edit
> 
> ... //depot/dev/nfx-tree/code/sm-ea/ea-cfgd-rx.c#11 edit
> 
> ... //depot/dev/nfx-tree/code/sm-ea/ea-cfgd.c#8 edit
> 
> ... //depot/dev/nfx-tree/code/sm-eee/eee-app.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/sm-elog/elog-api.h#2 edit
> 
> ... //depot/dev/nfx-tree/code/sm-event/emrs-api.c#3 edit
> 
> ... //depot/dev/nfx-tree/code/sm-event/event-as-openbsd.c#1 edit
> 
> ... //depot/dev/nfx-tree/code/sm-event/event-as.c#9 edit
> 
> ... //depot/dev/nfx-tree/code/sm-event/openbsd.h#1 edit
> 
> ... //depot/dev/nfx-tree/code/sm-evm/evm-cfgd.c#7 edit
> 
> ... //depot/dev/nfx-tree/code/sm-fs/fs-shell.c#25 edit
> 
> ... //depot/dev/nfx-tree/code/sm-fs/fsdb-read-block.c#9 edit
> 
> ... //depot/dev/nfx-tree/code/sm-fs/restore/restore.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/sm-fs/sanm_test.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/sm-fs/snapadmin#1 edit
> 
> ... //depot/dev/nfx-tree/code/sm-ndmp/nscadmin#1 edit
> 
> ... //depot/dev/nfx-tree/code/sm-opt/fs-linux.c#4 edit
> 
> ... //depot/dev/nfx-tree/code/sm-opt/fs-openbsd.c#6 edit
> 
> ... //depot/dev/nfx-tree/code/sm-opt/opt-api.h#4 edit
> 
> ... //depot/dev/nfx-tree/code/sm-sct/sct-ccc-ssl.c#7 edit
> 
> ... //depot/dev/nfx-tree/code/sm-sct/sct-http.c#6 edit
> 
> ... //depot/dev/nfx-tree/code/sm-sct/sct.c#7 edit
> 
> ... //depot/dev/nfx-tree/code/sm-sct/taskmgr.c#9 edit
> 
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-conf.h#1 edit
> 
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-devcap#4 edit
> 
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-init-devcap.c#4 edit
> 
> ... //depot/dev/nfx-tree/code/sm-sdm/sdm-main.c#4 edit
> 
> ... //depot/dev/nfx-tree/code/sm-sdm/storage.c#5 edit
> 
> ... //depot/dev/nfx-tree/code/sm-test/how-to-garfield#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-authen-lib/authen-lib-api.h#3 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-authen-lib/authen-lib.c#9 edit
> 
> ...
> //depot/dev/nfx-tree/code/ssc-authen-lib/authen-localaccounts-api.h#2
> edit
> 
> ... //depot/dev/nfx-tree/code/ssc-authen-lib/cifs-map-cfg.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-authentication/auth-cifs.c#9 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-cluster/clusdb-tools.c#6 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-api.c#8 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#17 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-server.c#4 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-test.c#9 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.c#4 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.h#4 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-elog/elog.c#5 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-ncm/ncm.c#8 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-ncm/ncm.h#4 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-ndmp/ndmp-main.c#8 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-ndmp/ndmp-ssc.h#2 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxnis/nfxnis-loc.h#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#5 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_admin.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#5 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#7 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_disk.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#6 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#6 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#12 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_help.c#15 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_ndmp.c#3 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_port.c#6 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#5 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_rcon.c#3 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sanm.c#6 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_scsi.c#4 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysHealth.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysdvt.c#3 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#5 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#31 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#13 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/initialconfig.sh#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#6 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/selecttz#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/test/nfxsh-priv-test.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#3 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_main.c#8 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-openafs-ubik/beacon.c#8 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-openafs-ubik/recovery.c#5 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.c#9 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.h#4 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-pm/pm-mcp.c#7 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-pm/pm.c#9 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.all.linux#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.all.openbsd#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.init.linux#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.init.openbsd#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.linux#2 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-pm/pmtab.openbsd#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-pm/rc.agile#5 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c#4 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-rmc/rmc_util.c#3 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-sanm/sanm-private.h#3 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-support/cpucrash.sh#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-support/emrscron#7 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-support/replay_nfs_show_all.sh#1
> edit
> 
> ... //depot/dev/nfx-tree/code/ssc-support/support.sh#8 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-timekeeper/timekeep-api.h#4 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-vsd/vs-daemon.c#24 edit
> 
> ... //depot/dev/nfx-tree/extra/strip.sh#1 edit
> 
> ... //depot/dev/nfx-tree/test/lib/ONStor/Expect/GW/fscmd.pm#2 edit
> 
> ... //depot/dev/nfx-tree/test/lib/ONStor/Expect/Ssh.pm#5 edit
> 
> ... //depot/dev/nfx-tree/test/runtests#4 edit
> 
> ...
> //depot/dev/nfx-tree/test/t/all/features/filesystem/stress/StressTest/Ga
> tewayMonitor.pm#1 edit
> 
> ... //depot/dev/openbsd/src/etc/Makefile#4 edit
> 
> ... //depot/dev/openbsd/src/etc/crontab#1 edit
> 
> ... //depot/dev/openbsd/src/etc/flash_install.sh#1 delete
> 
> ... //depot/dev/openbsd/src/etc/inetd.conf#1 edit
> 
> ... //depot/dev/openbsd/src/etc/master.passwd#1 edit
> 
> ... //depot/dev/openbsd/src/etc/master.passwd.org#1 edit
> 
> ... //depot/dev/openbsd/src/etc/mtree/4.4BSD.dist#2 edit
> 
> ... //depot/dev/openbsd/src/etc/newsyslog.conf#1 edit
> 
> ... //depot/dev/openbsd/src/etc/rc#5 edit
> 
> ... //depot/dev/openbsd/src/etc/rc.initial#4 edit
> 
> ... //depot/dev/openbsd/src/etc/rc.local#1 edit
> 
> ... //depot/dev/openbsd/src/etc/rc.shutdown#1 edit
> 
> ... //depot/dev/openbsd/src/etc/root/dot.cshrc#1 edit
> 
> ... //depot/dev/openbsd/src/etc/root/dot.profile#1 edit
> 
> ... //depot/dev/openbsd/src/etc/syslog.conf#1 edit
> 
> ... //depot/dev/openbsd/src/etc/welcome.agile#1 delete
> 
> ... //depot/dev/openbsd/src/etc/welcome.onstor#1 branch
> 
> ... //depot/dev/openbsd/src/krb5-1.4.2/src/Makefile#1 edit
> 
> ... //depot/dev/openbsd/src/libexec/ld.so_elf/ld.so/library.c#1 edit
> 
> ...
> //depot/dev/openbsd/src/usr.sbin/dhcp/dhclient/scripts/dhclient-script#7
> edit
> 
> ... //depot/dev/prom/bc/Includes/nfx-defs.h#1 edit
> 
> ... //depot/dev/prom/cg/Includes/nfx-defs.h#1 edit
> 
> ... //depot/dev/prom/ch/Includes/nfx-defs.h#1 edit
> 
