AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20071221143307.7fcc0ba8@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>,<tim.gardner@onstor.com>,<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAIL7rGPUHzNTEHR00007827@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 21 Dec 2007 14:33:16 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Rendell Fong <rendell.fong@onstor.com>
Cc: Tim Gardner <tim.gardner@onstor.com>, Larry Scheer
 <larry.scheer@onstor.com>
Subject: Re: PERFORCE change 27121 for review
Message-ID: <20071221143316.72a2176c@ripper.onstor.net>
In-Reply-To: <WEBMAIL7rGPUHzNTEHR00007827@mail.onstor.com>
References: <WEBMAIL7rGPUHzNTEHR00007827@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On 21 Dec 2007 12:12:00 -0800 Rendell Fong <rendell.fong@onstor.com>
wrote:

> Change 27121 by rendellf@rendellf on 2007/12/21 12:00:05
> 
> 	Update directory path for mount/umount command for Linux.
> 	   Reviewed By: LarryS
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-opt/linux.h#2 edit
> ... //depot/dev/nfx-tree/code/sm-opt/openbsd.h#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#9 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#15 edit
> 
> 
> http://liszt:1818/@md=d&cd=//depot/$c=G35@/27121?ac=10

Hi Rendell/Larry,

A few notes on these changes:

nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c:

line 952:
I have a feeling Linux uses /etc/defaultroute rather than /etc/mygate

Basically, it looks like cmd_flash.c was never ported, just copied to
two files and the exact minimum changes made to permit compiling.  So
some of the changes Rendell has made, while excellent improvements in
portability, are only in the Linux version.  Unless Rendell is the
original person who was supposed to do this file, it's not his fault,
but I just wanted to make sure we note that this work still has yet to
be done.  Ie., cmd_flash.c has not actually been ported.

nfx-tree/code/ssc-nfxsh/cmd_upgrade.c:

line 1742:

please no ifdefs

The password database files need to be copied, not reproduced.  And the
equivalent files on Linux need to be copied too, namely /etc/shadow
and /etc/gshadow, so these files should be added to the list of files
to be copied for each OS, even though that part of sm-opt HASN'T BEEN
PORTED EITHER!  So this can just be handled by having all the right
files in the config files list.

I should note that there might be some good reason why these areas
weren't ported, really I just want to make sure that we know that it
needs to be done.

Cheers,

a


