AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080110185902.6e0ac96b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C92A8@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 10 Jan 2008 18:59:22 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please Review flash_install.sh
Message-ID: <20080110185922.0e415acb@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C92A8@onstor-exch02.onstor.net>
References: <20080110184312.5f0e3585@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C92A8@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Alright,

nfx-tree/Tools/flash_install.sh

     line 86, now that i look at the code, you don't need to modify
     get_lin_root_disk at all, it's fine like it is.

     line 515 and friend, leave the comment as it is, and just add
     the extra line to the case statement as you did.

the other changes are good (and necessary).

Thanks,

a




On Thu, 10 Jan 2008 18:44:54 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I am. I also have a few collateral tasks I need to do and getting
> flash_install to work was necessary to complete those tasks might as
> well submit the fix.
> 
> Cheers!
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, January 10, 2008 6:43 PM
> To: Larry Scheer
> Subject: Re: Please Review flash_install.sh
> 
> Larry, you're supposed to be working on verify_install.sh, not
> flash_install.sh
> 
> On Thu, 10 Jan 2008 18:41:30 -0800 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > P4 client is larrys
> > Workspace is on mightydog : /homes/larrys/dev/src
> > 
> > Change 27279 by larrys@larrys on 2008/01/10 13:30:13 *pending*
> > 
> >         Fixes to get flash install to work in the case where
> >         you are booted from an NFS root filesystem.
> >         Reviewed by: AndyS
> > 
> > Affected files ...
> > 
> > ... //depot/dev/nfx-tree/Tools/flash_install.sh#4 edit
> > 
