AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080116132907.38c79d9f@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>,<tim.gardner@onstor.com>,<sripal.surendiran@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C92CD@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 16 Jan 2008 13:29:36 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Cc: "Tim Gardner" <tim.gardner@onstor.com>, "Sripal Surendiran (HCL)"
 <sripal.surendiran@onstor.com>
Subject: Re: please review change: re-arranging code from sm-opt and
 ssc-optlib directories
Message-ID: <20080116132936.2a5750e6@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C92CD@onstor-exch02.onstor.net>
References: <20080116120705.3d8e6c81@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C92CD@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 16 Jan 2008 13:17:20 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I may need a bit longer to look at the Makefiles. I just started
> reviewing them. Here is what I have so far.
> 
> nfx-tree/Makefile.ssc -- I did not see any differences

$ p4 diff nfx-tree/Makefile.ssc
==== //depot/dev/nfx-tree/Makefile.ssc#10 - /homes/andys/flash/dev/nfx-tree/Makefile.ssc ====
60d59
<                       ssc-optlib \
70a70
>                       ssc-initial-config \


> nfx-tree/Makefile.tmfc -- This is an obsolete Makefile -- unless it

This was the only file I could find that mentioned sm-opt.  It gets
included from the nfx-tree/Makefile, so possibly it's not entirely
unused?  Somehow that code was being built.

> used for PROM builds somehow which I doubt.
> 
> 
> Again I am still looking at your changes.

You have 60 seconds left....

> Larry
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, January 16, 2008 12:07 PM
> To: Andy Sharp
> Cc: Larry Scheer; Tim Gardner; Sripal Surendiran (HCL)
> Subject: Re: please review change: re-arranging code from sm-opt and
> ssc-optlib directories
> 
> Deadline on this review is 1.30pm today.  I've heard from Tim I
> believe, but I'd like to hear from Larry.  Sripal is probably sleeping
> but had his chance.  This is a blocker on porting cmd_flash.c which I
> have a deadline on as well.
> 
> Changes are small, if you whip through them, shouldn't take more than
> 10-15 minutes.
> 
> Thanks,
> 
> a
> 
> On Fri, 11 Jan 2008 22:50:54 -0800 Andrew Sharp
> <andy.sharp@onstor.com> wrote:
> 
> > I am porting ssc-nfxsh/cmd_flash.c to linux (actually, I'm porting
> > it period, as it was never ported) and in the process discovered
> > that some refactoring needed to take place.  Most of the files
> > changed in this change list are just being moved, or they need to
> > be modified slightly because of the moved files.
> > 
> > The files that are being moved out of sm-opt and ssc-optlib will
> > also need modifying, but in this checkin they are only moved.  A
> > subsequent checkin will fix them w/o losing the history of where
> > they came from. Those changes have already been made and tested: it
> > builds at least ~:^)
> > 
> > All the code from these directories is moved to ssc-genlib, except
> > the initial-config stuff, which gets its own directory now --
> > ssc-initial-config -- which makes sense because there will probably
> > be more files added to that directory soon.
> > 
> > 
> > Change 27264 by andys@ripper-temp on 2008/01/09 09:53:31 *pending*
> > 
> > 	Precursor to porting the cmd_flash code.
> > 	
> > 	Step 1: flower arranging.
> > 	
> > 	The sm-opt and ssc-optlib directories at one time had
> > rational stuff in them, but not anymore.  It's time to move this
> > code, and consolidate it with other code, to a place that is more
> > 	apropriate for what it currently does -- ssc-genlib.
> > 	
> > 	Move the initial config stuff out of ssc-optlib into it's
> > own directory, because it doesn't belong where it is or anywhere
> > 	else I can think of.
> > 	
> > 	Fix the includes for all C files that were including one of
> > 	the moved header files opt-api.h (now renamed to
> > optlib-api.h) and opt-fs-internal.h (now renamed to fs.h).
> > opt-api.h will likely get folded into ssc-genlib/genlib.h.
> > 	
> > 	Fix the makefiles that were specifying the opt library and
> > 	sm-opt and ssc-optlib directories.
> > 	
> > 	The moved files themselves need fixing, which will be done
> > in a separate checkin immediately following this one.
> > 	
> > 	Delete unused source file sm-ipmd/ipmd-vif.c
> > 	
> > 	Reviewed by
> > 
> > Affected files ...
> > 
> > ... //depot/dev/nfx-tree/Includes/opt-msgs.h#1 branch
> > ... //depot/dev/nfx-tree/Makefile.ssc#9 edit
> > ... //depot/dev/nfx-tree/Makefile.tmfc#1 edit
> > ... //depot/dev/nfx-tree/Tools/genmake#1 edit
> > ... //depot/dev/nfx-tree/code/sendmail/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/sm-bsd-snmpd/agent/agent_onstor.c#4
> > edit ... //depot/dev/nfx-tree/code/sm-coredump/coredump.h#2 edit
> > ... //depot/dev/nfx-tree/code/sm-ea/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/sm-elog/openbsd.h#1 edit
> > ... //depot/dev/nfx-tree/code/sm-event/Makefile#3 edit
> > ... //depot/dev/nfx-tree/code/sm-event/asd.c#8 edit
> > ... //depot/dev/nfx-tree/code/sm-event/event-api.h#4 edit
> > ... //depot/dev/nfx-tree/code/sm-event/event-as-linux.c#1 edit
> > ... //depot/dev/nfx-tree/code/sm-event/event-as-openbsd.c#2 edit
> > ... //depot/dev/nfx-tree/code/sm-event/event-as.c#10 edit
> > ... //depot/dev/nfx-tree/code/sm-event/event-as.h#4 edit
> > ... //depot/dev/nfx-tree/code/sm-event/event.c#11 edit
> > ... //depot/dev/nfx-tree/code/sm-evm/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/sm-evm/evm-com-defs.h#12 edit
> > ... //depot/dev/nfx-tree/code/sm-file/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/sm-fs/Makefile#2 edit
> > ... //depot/dev/nfx-tree/code/sm-ipmd-lib/ipmd-lib.c#7 edit
> > ... //depot/dev/nfx-tree/code/sm-ipmd/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd-kern-linux.c#2 edit
> > ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd-kern-openbsd.c#2 edit
> > ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd-util.c#3 edit
> > ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd-vif.c#4 delete
> > ... //depot/dev/nfx-tree/code/sm-ipmd/ipmd.c#8 edit
> > ... //depot/dev/nfx-tree/code/sm-opt/Makefile#3 delete
> > ... //depot/dev/nfx-tree/code/sm-opt/eee.h#1 delete
> > ... //depot/dev/nfx-tree/code/sm-opt/fs-linux.c#5 delete
> > ... //depot/dev/nfx-tree/code/sm-opt/fs-openbsd.c#7 delete
> > ... //depot/dev/nfx-tree/code/sm-opt/fs.c#3 delete
> > ... //depot/dev/nfx-tree/code/sm-opt/linux.h#2 delete
> > ... //depot/dev/nfx-tree/code/sm-opt/openbsd.h#3 delete
> > ... //depot/dev/nfx-tree/code/sm-opt/opt-api.h#5 delete
> > ... //depot/dev/nfx-tree/code/sm-opt/opt-fs-internal.h#2 delete
> > ... //depot/dev/nfx-tree/code/sm-opt/tfs.c#2 delete
> > ... //depot/dev/nfx-tree/code/sm-sct/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/sm-sct/taskmgr.c#12 edit
> > ... //depot/dev/nfx-tree/code/sm-spm/spm.h#4 edit
> > ... //depot/dev/nfx-tree/code/sm-tape/tape-msg.c#7 edit
> > ... //depot/dev/nfx-tree/code/sm-tape/tape-rmc.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-authen-lib/cifs-map-cfg.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-authentication/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/Makefile#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#18
> > edit ... //depot/dev/nfx-tree/code/ssc-elog/Makefile#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-elog/elog.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/fs-api.h#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-genlib/fs-linux.c#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-genlib/fs-linux.h#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-genlib/fs-openbsd.c#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-genlib/fs-openbsd.h#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-genlib/fs.c#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-genlib/fs.h#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-genlib/redo-hosts.c#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-genlib/tfs.c#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c#9 edit
> > ... //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-openbsd.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-initial-config/Makefile#1 add
> > ... //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.c#1
> > branch ...
> //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.h#1
> > branch ... //depot/dev/nfx-tree/code/ssc-modify-ro/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/ssc-modify-ro/modify-ro.c#4 edit
> > ... //depot/dev/nfx-tree/code/ssc-ndmp/Makefile#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-ndmp/ndmp-agil-tbl.c#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxnis/cfg_nfxnis.c#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_admin.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#8 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cluster.c#17 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#9 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#14 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_idmap.c#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_ndmp.c#4 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_privileges.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#35 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#16 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-openbsd.c#9 edit
> > ... //depot/dev/nfx-tree/code/ssc-optlib/Makefile#6 delete
> > ... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.c#11 delete
> > ... //depot/dev/nfx-tree/code/ssc-optlib/initial-config.h#5 delete
> > ... //depot/dev/nfx-tree/code/ssc-optlib/redo_hosts.c#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-sshd-kb5/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/ssc-tests/Makefile#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-timekeeper/Makefile#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils-linux.c#2
> > edit ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils-openbsd.c#2
> > edit ... //depot/dev/nfx-tree/code/ssc-timekeeper/ntp_utils.c#9 edit
> > ... //depot/dev/nfx-tree/code/ssc-vsd/Makefile#2 edit
> > ... //depot/dev/nfx-tree/code/ssc-vsd/vs-ipm.c#10 edit
> > ... //depot/dev/nfx-tree/code/ssc-vtm/Makefile#1 edit
> > 
