AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080128104926.6e7f94fb@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E07FB4CAF@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 28 Jan 2008 10:49:31 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: please review 27188
Message-ID: <20080128104931.72e9f6ec@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E07FB4CAF@onstor-exch02.onstor.net>
References: <20080125180032.6993ea64@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E07E60260@onstor-exch02.onstor.net>
	<20080128103303.43ecb577@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E07FB4CAF@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

nfxsh is built with -linitial-conf, not the other way around.  another
module besides nfxsh, which does not link with libnfxsh, also needs to
build with -linitial-config and should not link with libnfxsh.

On Mon, 28 Jan 2008 10:37:22 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> I don't get it. Why exactly linking with libnfxsh did not work?
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Monday, January 28, 2008 10:33 AM
> >To: Maxim Kozlovsky
> >Subject: Re: please review 27188
> >
> >Yeah, well, if it was that simple, I could have been done with this a
> >week ago.
> >
> >Some other module links with initial-config that has nothing to do
> >with nfxsh, hence the movement.  These functions in memory and
> >vector aren't really nfxsh specific anyway, so other modules can use
> >them now if they wanted.  I have no idea why they might want to, but
> >hey.
> >
> >On Fri, 25 Jan 2008 18:34:12 -0800 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Why do you need to move stuff out of nfxsh directory? Initial
> >> config could simply link libnfxsh.so.
> >>
> >> >-----Original Message-----
> >> >From: Andy Sharp
> >> >Sent: Friday, January 25, 2008 6:01 PM
> >> >To: Maxim Kozlovsky
> >> >Subject: please review 27188
> >> >
> >> >Change 27188 by andys@ripper on 2008/01/02 14:03:01 *pending*
> >> >
> >> >	Port cmd_flash and friends rather than just checking
> >> >	in some ancient copy:
> >> >            integrate cmd_flash-openbsd.c back to cmd_flash.c;
> >> >            create cmd_flash-OS.c files;
> >> >            actually put some code in fs-linux.c.
> >> >
> >> >	Since initial-config uses some of these routines, move
> >> >	appropriate code to genlib from ssc-nfxsh directory.
> >> >
> >> >	Adjust/cleanup includes accordingly in many nfxsh files.
> >> >
> >> >	reviewed by maximk
> >> >
> >> >
> >> >Affected files ...
> >> >
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/config.linux.h#1 branch
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/config.openbsd.h#1 branch
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/fs-api.h#2 edit
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/fs-linux.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/fs-openbsd.c#2 edit
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/fs.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/fs.h#2 edit
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/linux.h#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/log.c#1 add
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/log.h#1 branch
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/memory.c#1 branch
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/memory.h#1 branch
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/openbsd.h#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/vector.c#1 branch
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/vector.h#1 branch
> >> >... //depot/dev/nfx-tree/code/ssc-genlib/zebra.h#1 add
> >> >... //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.c#2
> >> edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#9 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/buffer.c#2 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_admin.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_arp.c#2 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#7 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#9 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cifs.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cifssrvr.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cluster.c#20 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cshare.c#6 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_disk.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_domain.c#8 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#8 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_filesystem.c#8 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#11 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#15
> >> >edit ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_gns.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_help.c#16 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_idmap.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_interface.c#12 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_localmap.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_localuseraccounts.c#4
> >> >edit ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_lvol.c#15 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nameservice.c#2 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_ndmp.c#5 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c#11 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_port.c#7 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_privileges.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#9 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_quota.c#11 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_raid.c#2 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_rcon.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_remoteaccess.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_route.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sanm.c#10 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_scsi.c#5 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_snapshot.c#11 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_snmp.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_spool.c#16 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_stats.c#11 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_symlinkmap.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysHealth.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysdvt.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-linux.c#6 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#6
> >> >edit ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#38 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_tape.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#19 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vif.c#6 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#38 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vscan.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vsvr.c#15 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/command.c#4 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/command.h#1 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/config.h#1 delete
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/config.h.bsd#1 delete
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/config.h.linux#1 delete
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/getopt.c#3 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/getopt1.c#2 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/linklist.c#2 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#7 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/log.c#2 delete
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/log.h#1 delete
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/memory.c#2 delete
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/memory.h#1 delete
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#7 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#6 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/vector.c#2 delete
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/vector.h#1 delete
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/vty.c#7 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-linux.c#1 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-openbsd.c#10 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh.c#8 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_config.c#7 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_main.c#10 edit
> >> >... //depot/dev/nfx-tree/code/ssc-nfxsh/zebra.h#1 delete
> >>
