AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080131115324.50cf085b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<tim.gardner@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E080589AB@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 31 Jan 2008 11:53:43 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Tim Gardner" <tim.gardner@onstor.com>
Subject: Re: PERFORCE change 27546 for review
Message-ID: <20080131115343.2649de7a@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E080589AB@onstor-exch02.onstor.net>
References: <WEBMAILKDG6UBWXV9R500004c8c@mail.onstor.com>
	<BB375AF679D4A34E9CA8DFA650E2B04E080589AB@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hmm, must be a typo where I had GPL and meant to delete it.  It
couldn't possibly mean "poor little".

On Thu, 31 Jan 2008 11:33:26 -0800 "Tim Gardner"
<tim.gardner@onstor.com> wrote:

> What's a PL?
> 
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Thursday, January 31, 2008 10:18 AM
> > To: Amit Bothra; Andy Sharp; Brian DeForest; Charissa Willard; Chris
> > Vandever; Danqing Jin; Deepak Veliath; Eric Barrett; Henry Lau; Ian
> Brown;
> > Jobi Ariyamannil; Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim
> > Kozlovsky; Mike Lee; Sandrine Boulanger; Svati Chandra; Tim Gardner;
> > Yuvarani Cothandaraman
> > Subject: PERFORCE change 27546 for review
> > 
> > Change 27546 by andys@ripper on 2008/01/31 05:15:59
> > 
> > 	Move GNU licensed code out of genlib.  Because PL
> > 	Max is afraid of the big bad GPL.  Also it's a bit
> > 	better split of the code, although it is a bit strange
> > 	to have some mount functions in lib zebra.
> > 
> > 	Oh yeah, fix several bugs too, including: get_device_names()
> > 	not switching the device names like it is supposed to;
> > 	mount_secondary() switched to using modify_readonly_file()
> instead
> > 	of it's own code, but the logic afterwards wasn't right;
> mkpath()
> > 	was modifying the path argument but it shouldn't; too many
> others
> > 	to keep listing them.
> > 
> > 	reviewed by larrys
> > 
> > Affected files ...
> > 
> > ... //depot/dev/nfx-tree/code/sm-sct/Makefile#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/config.linux.h#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-genlib/config.openbsd.h#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-genlib/fs-api.h#4 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/fs.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/log.c#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-genlib/log.h#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-genlib/memory.c#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-genlib/memory.h#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-genlib/redo-hosts.c#3 delete
> > ... //depot/dev/nfx-tree/code/ssc-genlib/vector.c#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-genlib/vector.h#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-genlib/zebra.h#2 delete
> > ... //depot/dev/nfx-tree/code/ssc-initial-config/initial-config.c#4
> edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#11 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/buffer.c#4 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_admin.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_arp.c#4 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#9 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#11 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cifs.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cifssrvr.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cluster.c#22 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cshare.c#8 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_disk.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_domain.c#10 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#10 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_filesystem.c#10 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#13 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_gns.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_help.c#18 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_idmap.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_interface.c#14 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_localmap.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_localuseraccounts.c#6
> > edit ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_lvol.c#18 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nameservice.c#4 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c#14 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_port.c#9 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_privileges.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#11 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_quota.c#13 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_raid.c#4 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_rcon.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_remoteaccess.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_route.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sanm.c#12 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_scsi.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_snapshot.c#13 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_snmp.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_spool.c#18 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_stats.c#13 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_symlinkmap.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysHealth.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_sysdvt.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-linux.c#8 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#8 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#40 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_tape.c#5 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#21 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vif.c#8 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#40 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vscan.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vsvr.c#18 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/command.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/command.h#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/linklist.c#4 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#10 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/vty.c#9 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-linux.c#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh-openbsd.c#12 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh.c#10 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_config.c#9 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_main.c#12 edit
> > ... //depot/dev/nfx-tree/code/ssc-zebra/Makefile#1 add
> > ... //depot/dev/nfx-tree/code/ssc-zebra/config.linux.h#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-zebra/config.openbsd.h#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-zebra/fs-vector.h#1 add
> > ... //depot/dev/nfx-tree/code/ssc-zebra/log.c#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-zebra/log.h#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-zebra/memory.c#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-zebra/memory.h#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-zebra/vector.c#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-zebra/vector.h#1 branch
> > ... //depot/dev/nfx-tree/code/ssc-zebra/zebra.h#1 branch
> > 
> > 
> > http://liszt:1818/@md=d&cd=//depot/$c=G35@/27546?ac=10
