AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080201150145.64e690b4@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>,<tim.gardner@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9330@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 1 Feb 2008 15:04:19 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Cc: "Tim Gardner" <tim.gardner@onstor.com>
Subject: Re: Please Review system upgrade port
Message-ID: <20080201150419.092d7842@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9330@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9330@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 31 Jan 2008 20:17:49 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Tim, Andy,
>    Whoever wants to review these changes or can review these changes
> please do. System upgrade is working on cougars and I didn't break
> anything on bobcats. I still have more testing to do. But this work is
> the final bits that get the functionality in place. 
> 
> I hope having my changes on linux-compile doesn't cause any grief. I
> made the changes on the system I do the builds from.

parse error -----------------------------------------^

> I do have this workspace mounted on Ripper. I also opened the files
> and copied them to my p4 client named larrys workspace:
> /homes/larrys/src/dev.
> 
> P 4 client is larrys-r14-dmip
> 
> My workspace is here: /home/larrys/perforce/trees/dev/nfx-tree
> 
> Change 27565 by larrys@larrys-r14-dmip on 2008/01/31 15:01:39
> *pending*
> 
>         System upgrade port to Linux
> 
>          nfx-tree/Makefile; nfx-tree/$(OS).mk
>           Bom file rules skip over var/log var/run share/doc and
> share/man
>           this will keep these files from being installed.
>           Add back in cw_install.sh for BSD release.
> 
>          ssc-nfxsh/verify_install.sh
>           Lots of changes for portability and some improvements.
> 
>          ssc-nfxsh/cmd_upgrade.c; ssc-nfxsh/linux.h;
> ssc-nfxsh/openbsd.h Port for mounting memory file system with both
> BSD and Linux. Removed code for reading descr file nothing was being
> done with
>           the info read by functions in cmd_upgrade. Verify_install is
>           using the descr file to do useful work.
>           Removed running mtree as part of the BSD install. No need
>           to do this any more in BSD because tar creates the hierarchy
> for
>           us and Linux doesn't have mtree. 
> 
>          extra/strip.sh
>           Stripping libbsdcompat.so.1.0 was producing "file truncated"
>           messages. Skip stripping this library. It is a dummy lib
>           in BSD builds anyway. (This script only used in the BSD
>           platforms
> 
>          Reviewed by: Andys TimG
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/Makefile#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#21 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#8 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#5 edit
> ... //depot/dev/nfx-tree/extra/strip.sh#2 edit
> ... //depot/dev/nfx-tree/linux.mk#2 edit
> ... //depot/dev/nfx-tree/openbsd.mk#5 edit

I don't have time to review verify_install.sh today, but I've done the
other files.  I will try to find time for verify_install.sh during the
stuperbowl commercials.

Here is the partial review so far.

nfx-tree/Makefile


     line 698, you have different regexes.  they should be the same
     at the beginning.  same for the case statement just below it.
     it's a good thing you ignore these paths, because on linux the
     tar exclude argument in flash_install isn't working.




nfx-tree/code/ssc-nfxsh/cmd_upgrade.c


     line 154, delete this line

     line 737, instead of doing this, just remove the size restriction
     on /tmp

     line 1871, do not surround with ifdef.  instead, leave original
     declaration of i, and add a line just before become_root() call
     setting i=0 so linux compilation won't complain about it.

     line 2328, same as above.


nfx-tree/code/ssc-nfxsh/linux.h

     definitely not what we want to do, for several reasons.  one of
     them is just change our fstab instead.  i think.


nfx-tree/code/ssc-nfxsh/openbsd.h


     whatever




