AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9346@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 5 Feb 2008 15:58:47 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Status of Review of Change list 27565
Message-ID: <20080205155847.5dddc4cf@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9346@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9346@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 4 Feb 2008 14:13:39 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
>    I am waiting on the review of verify_install.sh. If I don't here
> from you by 4 PM I am going to submit change 27565.
> 
> Larry

nfx-tree/Makefile

     line 698, you have different regexes.  they should be the same
     at the beginning.  same for the case statement just below it.
     it's a good thing you ignore these paths, because on linux the
     tar exclude argument in flash_install isn't working.


nfx-tree/code/ssc-nfxsh/cmd_upgrade.c


     line 154, delete this line

     line 737, instead of doing this, just remove the size restriction
     on /tmp

     line 1871, do not surround with ifdef.  instead, leave original
     declaration of i, and add a line just before become_root() call
     setting i=0 so linux compilation won't complain about it.

     line 2328, same as above.



nfx-tree/code/ssc-nfxsh/linux.h


     definitely not what we want to do, for several reasons.  one of
     them is, just change our fstab instead.



nfx-tree/code/ssc-nfxsh/openbsd.h

     sure

nfx-tree/code/ssc-nfxsh/verify_install.sh

     line 244 what does get_standy_root mean?

     line 301

     sdev=`echo $sdev | sed "s+/dev/${DISK}.+$s_base+"`

     I believe this will take /dev/sda1 and change it to /dev/sdb
     instead of /dev/sdb1

     line 380

     fsck is only necessary on openbsd

     line 500

     probably shouldn't exit here, but instead have a complete error
     return path.

     line 892

     sync only needed on linux, openbsd does everything synchronously

     line 923, if we don't need to remount CF dirs, then we don't need
     this comment

     line 990, and 996, and 1002, and 1007, indenting is messed up


nfx-tree/extra/strip.sh

     just use an if not a case:
	 if $i != libbsdcompat then strip $i fi

nfx-tree/linux.mk

     looks good

nfx-tree/openbsd.mk

     line 41-43 it looks like you've added a 'c' to the beginning of
          these variable names, which will break the script


