AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080206175115.0c9a0981@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C935E@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 6 Feb 2008 17:51:34 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 27669
Message-ID: <20080206175134.2ac576c6@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C935E@onstor-exch02.onstor.net>
References: <20080206154623.6eb0e44d@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C935E@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 6 Feb 2008 16:38:11 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c
> 
>      Line: 35 How about adding /proc and /sys? Is this where that is
> done? And

Those are in there.

>      can subdirectories be added such as /var/empty and /lib/init/rw?

they can be, but aren't yet.  /var/empty?  say it ain't so.  crap, we
need to do something about not copying /lib/init/rw - damnit.

> I am hoping that by adding those the reboot after a system copy
>      all -i will work. If not here then in cmd_flash? Anyway rebooting
> from a flash created with system copy all -i didn't work because /proc
> and /sys were missing hence /proc was not being mounted and there were
> messages about /lib/init/rw/.ramfs missing.

/lib was also missing, as was static /dev

> nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c
> 
>      looks good
> 
> nfx-tree/code/ssc-nfxsh/cmd_flash.c
> 
>      Lines 62-71 Is this where /proc /var/empty /sys /lib/init/rw
>      should be added?

they are there already, in cmd_flash-linux.c


Please re-review, I think I made some more changes after you looked at
it?  I don't know how else you would miss the os_init_dirs logic.

> nfx-tree/code/ssc-nfxsh/linux.h
> 
>      looks good
> 
> nfx-tree/code/ssc-nfxsh/openbsd.h
> 
>      looks good
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, February 06, 2008 3:46 PM
> To: Larry Scheer
> Subject: please review 27669
> 
> Change 27669 by andys@ripper on 2008/02/06 09:36:40 *pending*
> 
>         System copy init and system copy all porting fixes:
>         
>         + Need to create some common and some OS specific extra
>           directories after initializing a flash.
>         
>         + Linux needs a little extra logic for system copy all.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#14 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-openbsd.c#17 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#9 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#9 edit
