AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080208185532.6ed8ba02@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E03B1C051@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 8 Feb 2008 18:56:04 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review 27712
Message-ID: <20080208185604.497c1846@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E03B1C051@onstor-exch02.onstor.net>
References: <20080208133841.537dd80f@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E03B1C051@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Doing the thing with verify_install.sh is harder, because it gets
unpacked from the distribution tar ball by itself and should have a
list that is from the same release.  There are other scripts that run
on the filer that need the list, so they should include it in case it
gets updated but the scripts don't.

On Fri, 8 Feb 2008 15:35:29 -0800 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Looks okay.  I'm not a makefile expert though.  One question:  Should
> the flash_install.sh script be generated like verify_install.sh during
> the make release?  Then you don't have to copy config-files and
> $OS-config-files into the release image and have to reference these
> files during execution.  Just wondering why both scripts are not
> handled in a consistent way.
> 
> Other than that this is a great step in the right direction.
> 
> Thanks,
> Rendell
> 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Friday, February 08, 2008 1:39 PM
> To: Rendell Fong
> Subject: please review 27712
> 
> Hi Rendell,
> 
> I sent an email to you yesterday about this, but it probably got put
> in your spam folder.
> 
> I've done a bit more work on it to make it complete last night, so I
> think it's possibly ready to check in.  Let me know.
> 
> Change 27712 by andys@ripper on 2008/02/07 13:22:03 *pending*
> 
>         Create one global list of config files for scripts and C code.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/linux/rootfs/Makefile#20 edit
> ... //depot/dev/linux/rootfs/etc/onstor/initial-config#7 edit
> ... //depot/dev/nfx-tree/Makefile#9 edit
> ... //depot/dev/nfx-tree/Tools/Linux-config-files#1 add
> ... //depot/dev/nfx-tree/Tools/OpenBSD-config-files#1 add
> ... //depot/dev/nfx-tree/Tools/config-files#1 add
> ... //depot/dev/nfx-tree/Tools/flash_install.sh#7 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs-linux.c#5 edit
> ... //depot/dev/nfx-tree/code/ssc-genlib/fs-openbsd.c#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/Makefile#11 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#1 add
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.sh#6 delete
