AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080212183843.0ad9f531@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E084968E6@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 12 Feb 2008 18:39:22 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: please review my change 22264 for patch install script
Message-ID: <20080212183922.0cb80652@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E084968E6@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E084968E6@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 11 Feb 2008 19:06:31 -0800 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> Added support for scp.  The syntax is scp://user@host/path .
> 
> 
> [edk@edk-linux Tools]$ p4 info
> User name: edk
> Client name: edk-dev
> Client host: edk-linux.onstor.net
> Client root: /homes/edk/p4/dev
> Current directory: /homes/edk/p4/dev/nfx-tree/Tools
> Client address: 10.0.0.137:59276
> Server address: liszt.onstor.net:1717
> Server root: /p4data/p4root
> Server date: 2008/02/11 14:07:09 -0800 PST
> Server version: P4D/LINUX26X86_64/2007.2/122958 (2007/05/23)
> Server license: ONStor 40 users (support expired 2007/07/03)
> 
> [edk@edk-linux Tools]$ p4 opened
> //depot/dev/nfx-tree/Tools/cw_install.in#8 - edit change 27779 (xtext)

I think you meant change 27779 not 22264.  Where did 22264 come from??

Comments:

nfx-tree/Tools/cw_install.in

     line 556-562 : i admit the original semantics of get_distball were
     akward and wrong. if you're going to do this, then might as well
     fix that too.  which would mean moving this code into get_distball.
     and eliminating the 'method' argument to get_distball.

     line 680 : just say 'ftp, http, scp URL ...' since the form is
     standard.  you can output a sample URL if you want, but make it
     generic for all methods.

