AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0856DE05@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 13 Feb 2008 12:37:03 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: please review my change 27779 for patch install script
Message-ID: <20080213123703.44efc8b0@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0856DE05@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E084968E6@onstor-exch02.onstor.net>
	<20080212183922.0cb80652@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0856DE05@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Fine by me.

On Wed, 13 Feb 2008 12:14:06 -0800 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> Yes, the change number is 27779.
> I've moved the "method" code to get_distball() per your suggestion.
> I've also added "sftp" support.  I'm adhering to the syntax of scp &
> sftp, which is slightly different than those of ftp/http, so I'm
> listing them all at the prompt:
> 
> Downloading the EverON software distribution.
> Please enter the ftp, http, scp or sftp URL of the distribution:
>   ftp://[user:password@]host[:port]/path
>   http://host[:port]/path
>   scp://[[user@]host:]path
>   sftp://[user@]host:path
> [ftp://support.onstor.com/outbound/software/EverON/3.0.1.0/22xx/EverON-3
> .0.1.0BC.tar.gz]
> 
> I'm open to other suggestions.
> 
> Thanks,
> Ed
> 
> > I think you meant change 27779 not 22264.  Where did 22264 come
> > from??
> > 
> > Comments:
> > 
> > nfx-tree/Tools/cw_install.in
> > 
> >      line 556-562 : i admit the original semantics of get_distball
> were
> >      akward and wrong. if you're going to do this, then might as
> > well fix that too.  which would mean moving this code into
> get_distball.
> >      and eliminating the 'method' argument to get_distball.
> > 
> >      line 680 : just say 'ftp, http, scp URL ...' since the form is
> >      standard.  you can output a sample URL if you want, but make it
> >      generic for all methods.
> 
