AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080213134111.3eb685bf@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<bunk@kernel.org>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	20080213213015.GZ3383@cs181133002.pp.htv.fi
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 13 Feb 2008 13:41:31 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Adrian Bunk <bunk@kernel.org>
Subject: Re: [2.6 patch] make ds1511_rtc_{read,set}_time() static
Message-ID: <20080213134131.37bac4e9@ripper.onstor.net>
In-Reply-To: <20080213213015.GZ3383@cs181133002.pp.htv.fi>
References: <20080213213015.GZ3383@cs181133002.pp.htv.fi>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 13 Feb 2008 23:30:15 +0200 Adrian Bunk <bunk@kernel.org> wrote:

> This patch makes the needlessly global ds1511_rtc_{read,set}_time() 
> static.

The reason they aren't static is that they need to be called from
platform code during boot.  But probably there is some generic/proper
way to do that which wouldn't require these to be global?

> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> 
>  drivers/rtc/rtc-ds1511.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> 2ca22d827507d309cfd7182b9360d1edca531072 diff --git
> a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c index
> d74b808..d82fd71 100644 --- a/drivers/rtc/rtc-ds1511.c
> +++ b/drivers/rtc/rtc-ds1511.c
> @@ -181,8 +181,7 @@ ds1511_wdog_disable(void)
>   * stupidly, some callers call with year unmolested;
>   * and some call with  year = year - 1900.  thanks.
>   */
> - int
> -ds1511_rtc_set_time(struct device *dev, struct rtc_time *rtc_tm)
> +static int ds1511_rtc_set_time(struct device *dev, struct rtc_time
> *rtc_tm) {
>  	u8 mon, day, dow, hrs, min, sec, yrs, cen;
>  	unsigned int flags;
> @@ -245,8 +244,7 @@ ds1511_rtc_set_time(struct device *dev, struct
> rtc_time *rtc_tm) return 0;
>  }
>  
> - int
> -ds1511_rtc_read_time(struct device *dev, struct rtc_time *rtc_tm)
> +static int ds1511_rtc_read_time(struct device *dev, struct rtc_time
> *rtc_tm) {
>  	unsigned int century;
>  	unsigned int flags;
> 
