AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080220143044.7ebcb2b3@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>,<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0875E2B4@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 20 Feb 2008 14:31:10 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Cc: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 27937
Message-ID: <20080220143110.74b08a16@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0875E2B4@onstor-exch02.onstor.net>
References: <20080220141254.2692db28@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0875E2B4@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 20 Feb 2008 14:18:14 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> What does "It" in "it builds" mean? Did you do a clean build? I am
> sure I did this for the reason and I don't appreciate your calling
> this "abuse". The world of Oss is not limited to linux and openbsd,
> you know. EEE is also an OS in some sense. 

Abuse of a variable is abuse whether you like it or not; don't blame the
messenger.  And this has nothing to do with "the world".  It's only
about SSC OS.  Perhaps you should learn not to take every bug you
create so heavily -- it will lead you to an early grave.
Especially small stuff like this.  Besides, it might have been an
existing variable that was unclearly defined, so it might not even be
your bug. That's what I meant about the variable should probably have
been called SSC_OS.

And yes, a [mostly] clean build.  What other kind is there?

> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Wednesday, February 20, 2008 2:13 PM
> >To: Larry Scheer; Maxim Kozlovsky
> >Subject: please review 27937
> >
> >I'm sending this to both of you because it involves makefiles and/or
> >code you may have written or know about.  Yes, I am a bit nervous
> >about it.  It builds on both cougar and bobcat/openbsd, but...
> >
> >Change 27937 by andys@ripper on 2008/02/19 14:20:57 *pending*
> >
> >        Ai-eee.
> >        Fix abuse of OS make variable.  This variable is limited
> >        to the two SSC operating systems, either openbsd or linux.
> >        eee is not one of those.  Really this variable should have
> >        been called SSC_OS or something, but that's probably
> >        already used for something completely different.
> >
> >        reviewed by
> >
> >Affected files ...
> >
> >... //depot/dev/nfx-tree/Includes/eee/ipm-if.h#1 delete
> >... //depot/dev/nfx-tree/Tools/defs.mk#11 edit
> >... //depot/dev/nfx-tree/code/sm-elog/eee.h#1 delete
> >... //depot/dev/nfx-tree/code/sm-ipmd-lib/eee.h#1 delete
