AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080220145026.1b8f559a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>,<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0875E2B4@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 20 Feb 2008 14:50:31 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Cc: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 27937
Message-ID: <20080220145031.7a6849cd@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0875E2B4@onstor-exch02.onstor.net>
References: <20080220141254.2692db28@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0875E2B4@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 20 Feb 2008 14:18:14 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> What does "It" in "it builds" mean? Did you do a clean build? I am
> sure I did this for the reason and I don't appreciate your calling
> this "abuse". The world of Oss is not limited to linux and openbsd,
> you know. EEE is also an OS in some sense.

Actually, I do hear what you're saying.  I started down the path of
creating a new variable, SSC_OS and setting OS_INCL based on that, but
I encountered some problem that involved intracacies with our include
files around nfxnis and rpc/xdr and stuff.  I couldn't get that resolved
after trying 3 or four different things, and then went this way instead.
While I can see a possible need for a 3-way variable, it seems we don't
really need one here, at least not now, as all the eee.h files were
empty anyway.

I didn't file a defect, but the problem is that if you say

#include OS_INCL

in a source file, that should be either linux.h or openbsd.h, not eee.h.
Because OS_INCL was based on the makefile variable OS, in some
directories it was 'eee', causing those source files to want to include
eee.h. But they either actually needed either linux.h or openbsd.h, or
neither. There were at least 3 places where we had a to include an
empty eee.h file to make the code compile.  One of those was
ssc-genlib, but I cleaned that up a few weeks ago.  That fix was not a
general one, however, and was actually just a consequence of changing
the way certain things worked in all that code.  OS was also being used
to set default include directories, and those were correctly 'eee' in a
small number of cases.

The problem came along when I needed to port sm-seep to Linux, and
including OS_INCL wouldn't work because that code is compiled with
OS=eee.  Since I'd had the problem before, I decided it was time to
implement a general fix.

So it's not a black/white case, it's more like a grey area, but one
that had to be resolved.

I didn't mean to ruffle any feathers, just trying to keep things light.
By abusing everyone.  Because that's so humourous.  Abusing variables
is bad, abusing people is OK as long as it's not me.


> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Wednesday, February 20, 2008 2:13 PM
> >To: Larry Scheer; Maxim Kozlovsky
> >Subject: please review 27937
> >
> >I'm sending this to both of you because it involves makefiles and/or
> >code you may have written or know about.  Yes, I am a bit nervous
> >about it.  It builds on both cougar and bobcat/openbsd, but...
> >
> >Change 27937 by andys@ripper on 2008/02/19 14:20:57 *pending*
> >
> >        Ai-eee.
> >        Fix abuse of OS make variable.  This variable is limited
> >        to the two SSC operating systems, either openbsd or linux.
> >        eee is not one of those.  Really this variable should have
> >        been called SSC_OS or something, but that's probably
> >        already used for something completely different.
> >
> >        reviewed by
> >
> >Affected files ...
> >
> >... //depot/dev/nfx-tree/Includes/eee/ipm-if.h#1 delete
> >... //depot/dev/nfx-tree/Tools/defs.mk#11 edit
> >... //depot/dev/nfx-tree/code/sm-elog/eee.h#1 delete
> >... //depot/dev/nfx-tree/code/sm-ipmd-lib/eee.h#1 delete
