AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080220153647.2643ac8e@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>,<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C93D5@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 20 Feb 2008 15:37:58 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Cc: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: please review 27937
Message-ID: <20080220153758.784f34bc@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C93D5@onstor-exch02.onstor.net>
References: <20080220141254.2692db28@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C93D5@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 20 Feb 2008 15:24:53 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> nfx-tree/Tools/defs.mk
> 
>      If it compiles and runs basic tests then this is ok.
> 
>      What I see as a "potential" problem is headers in Includes/eee
>      that have the same name as files in Includes/linux or
>      Includes/openbsd. I don't know if Max's intention of setting
>      OS=eee was just to get the include of Includes/eee or if it was
>      to get the include of Includes/eee and exlude Includes/linux
>      or Includes/openbsd. I didn't check the Includes directory for
>      headers with the same name.

There did used to be, but only because of this problem.  It's deletion
is part of the changelist ~:^)  And no, it obviously wasn't necessary,
since I didn't have to change any other file(s), just delete the
unnecessary cruft.

> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, February 20, 2008 2:13 PM
> To: Larry Scheer; Maxim Kozlovsky
> Subject: please review 27937
> 
> I'm sending this to both of you because it involves makefiles and/or
> code you may have written or know about.  Yes, I am a bit nervous
> about it.  It builds on both cougar and bobcat/openbsd, but...
> 
> Change 27937 by andys@ripper on 2008/02/19 14:20:57 *pending*
> 
>         Ai-eee.
>         Fix abuse of OS make variable.  This variable is limited
>         to the two SSC operating systems, either openbsd or linux.
>         eee is not one of those.  Really this variable should have
>         been called SSC_OS or something, but that's probably
>         already used for something completely different.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/Includes/eee/ipm-if.h#1 delete
> ... //depot/dev/nfx-tree/Tools/defs.mk#11 edit
> ... //depot/dev/nfx-tree/code/sm-elog/eee.h#1 delete
> ... //depot/dev/nfx-tree/code/sm-ipmd-lib/eee.h#1 delete
