AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080221150450.54954576@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C93E4@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 21 Feb 2008 15:04:56 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 27961
Message-ID: <20080221150456.4f43e996@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C93E4@onstor-exch02.onstor.net>
References: <20080220230631.35a90fd0@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C93E4@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 21 Feb 2008 14:55:35 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> linux/Pkgs/binary/Deb/exim4-config_4.63-17_all.deb
> 
>      looks good
> 
> linux/Pkgs/source/exim4/Makefile
> 
>      Lines 40 and 41. Maybe I am missing something here; but it
>      appears you are copying a file that is already inr BIN_PKG_DIR
>      to BIN_PKG_DIR?

good catch, fixed

> linux/Pkgs/source/exim4/debian.patch
> 
>      looks good
> 
> linux/rootfs/etc/exim4/exim4.conf.template
> 
>      looks good
> 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, February 20, 2008 11:07 PM
> To: Larry Scheer
> Subject: please review 27961
> 
> Change 27961 by andys@ripper on 2008/02/20 10:33:21 *pending*
> 
> 	Fix several small problems with exim4 package:
> 
> 	Fix typo in exim4 configuration template file that was
> 	causing configuration error.
> 
> 	Fix a few bugs in update-exim4defaults that was making
> 	it work not so well.
> 
> 	Remove change to exim logrotate config for new log file.
> 	Log file was put in onstor directory instead and onstor
> 	logrotate config file started in cl#27953
> 
> 	Change makefile to do the right thing if packages are up to
> 	date but not in perforce directory.
> 
> 	Add exim4-config to list of changed packages in makefile.
> 
> 	reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/linux/Pkgs/binary/Deb/exim4-config_4.63-17_all.deb#1
> edit ... //depot/dev/linux/Pkgs/source/exim4/Makefile#4 edit
> ... //depot/dev/linux/Pkgs/source/exim4/debian.patch#5 edit
> ... //depot/dev/linux/rootfs/etc/exim4/exim4.conf.template#3 edit
> 
