AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080226172349.37461e63@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/sent	0	20080226172244.4fdf2fa7@ripper.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 26 Feb 2008 17:24:03 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20080226172403.02438652@ripper.onstor.net>
In-Reply-To: <20080226172244.4fdf2fa7@ripper.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E08933977@onstor-exch02.onstor.net>
	<20080226172244.4fdf2fa7@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 26 Feb 2008 17:22:44 -0800 Andrew Sharp <andy.sharp@onstor.com>
wrote:

> On Tue, 26 Feb 2008 13:56:34 -0800 "Maxim Kozlovsky"
> <maxim.kozlovsky@onstor.com> wrote:
> 
> > Change 28061 by maximk@maximk-13 on 2008/02/26 08:57:23 *pending*
> > 
> >         22516
> >            Make the arguments compatible with old rcon and rename
> > rcon-new
> >            to rcon.
> >            Reviewed by andys.
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/rootfs/etc/inetd.conf#2 edit
> > ... //depot/dev/nfx-tree/Makefile.ssc#11 edit
> > ... //depot/dev/nfx-tree/code/ssc-rcon-new/Makefile#1 edit
> > ... //depot/dev/nfx-tree/code/ssc-rcon-new/rcon-new.c#2 edit
> > 
> 
>      please put the description of the bug in the comment, not just
>      the bug number.
> 
> 
> linux/rootfs/etc/inetd.conf
> 
>      looks good
> 
> nfx-tree/Makefile.ssc
> 
>      looks good
> 
> nfx-tree/code/ssc-rcon-new/Makefile
> 
>      looks good
> 
> nfx-tree/code/ssc-rcon-new/rcon-new.c
> 
>      line 33/66/73 if CPU and SLOT are supposed to be numbers, then
>      the usage should say so.  maybe the correct range for the system
>      the program is running on could be included

       like 0-3 or 1-2 or whatever.  that's something that casual user
       would likely not know.


>      line 108, I don't think you need a break after an exit.
> 
>      line 113, some error messages go to stdout, some to stderr.
>      George Bush says "unificate your error message strategy."
> 
