AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E08933EF6@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 27 Feb 2008 11:30:02 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20080227113002.5b2a4238@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E08933EF6@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E08933977@onstor-exch02.onstor.net>
	<20080226172244.4fdf2fa7@ripper.onstor.net>
	<20080226172403.02438652@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08933EF6@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

ok

On Tue, 26 Feb 2008 17:30:57 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> >>
> >>      line 33/66/73 if CPU and SLOT are supposed to be numbers, then
> >>      the usage should say so.  maybe the correct range for the
> >> system the program is running on could be included
> >
> >       like 0-3 or 1-2 or whatever.  that's something that casual
> > user would likely not know.
> [MK] ok
> >
> >
> >>      line 108, I don't think you need a break after an exit.
> [MK] 
> You don't need it but it is better to always put a break. People can
> change code, or copy paste a block of code, it is better if the block
> is always right.
> >>
> >>      line 113, some error messages go to stdout, some to stderr.
> >>      George Bush says "unificate your error message strategy."
> >>
> [MK] ok
