AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080228152132.3672642c@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9411@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 28 Feb 2008 15:21:59 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Perlease review
Message-ID: <20080228152159.721403d2@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9411@onstor-exch02.onstor.net>
References: <20080227181926.21e988bb@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9411@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 28 Feb 2008 12:03:17 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I spoke with Eric and asked his advice about error messages. He said a
> common tar failure problem is with customers ftp the file in ascii
> mode hence the message to verify the checksum of the distribution
> file.
> 
> I also noticed that I wasn't checking the return value of extract and
> handling the error.
> 
> Please re-review.


nfx-tree/code/ssc-nfxsh/cmd_upgrade.c

     looks good

nfx-tree/code/ssc-nfxsh/verify_install.in

     should lines 600 and 601 be swapped?  I'm not entirely sure myself.

     line 827, hey, i went to all the work to add a _sed function,
     please use it.  knucklehead.  besides, i thought we already had
     this bin/[ thang handled a long, long time ago.  did a problem
     turn up in recent testing?

     new message looks hexcellent.




> Larry
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, February 27, 2008 6:19 PM
> To: Larry Scheer
> Subject: Re: Perlease review
> 
> On Wed, 27 Feb 2008 16:08:41 -0800 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > This change is on my workspace on linux-compile but it is mounted on
> > ripper: /home/larrys/perforce/trees/dev
> > 
> > Change 28069 by larrys@larrys-r14-dmip on 2008/02/26 13:55:18
> > *pending*
> > 
> >         TED00022134
> >         System does not boot after system copy init followed by
> > system upgrade
> > 
> > Affected files ...
> > 
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#24 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#4 edit
> 
> 
> nfx-tree/code/ssc-nfxsh/cmd_upgrade.c
> 
> 
>      looks good
> 
> 
> nfx-tree/code/ssc-nfxsh/verify_install.in
> 
>      line 493 I really don't like error messages like this.  I think
>      this is fine/good for the log file, but I'd rather something
>      like that didn't come out on the console for customers to see.
>      I know this is extra work, but perhaps a log_only version of
>      'record' or a LOG_ONLY flag in opposition to the NO_RECORD flag.
>      Then say something like record "Problem unpacking the
> distribution, contact customer support" on the screen, and log the
> other message.
> 
>      line 495 close curly should match previous indent level
> 
>      Is the problem where .fresh-flash upgrades aren't getting all
>      the files needed addressed by calling extract w/o a filelist?
>      I'm just trying to understand that.
> 
