AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080229182037.4964e46a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAILDLOLICrrsPdT00007cc9@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 29 Feb 2008 18:21:06 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Maxim Kozlovsky <maxim.kozlovsky@onstor.com>
Subject: Re: PERFORCE change 28114 for review
Message-ID: <20080229182106.44758f3e@ripper.onstor.net>
In-Reply-To: <WEBMAILDLOLICrrsPdT00007cc9@mail.onstor.com>
References: <WEBMAILDLOLICrrsPdT00007cc9@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On 29 Feb 2008 16:48:44 -0800 Maxim Kozlovsky
<maxim.kozlovsky@onstor.com> wrote:

> Change 28114 by maximk@maximk-13 on 2008/02/29 11:49:31
> 
> 	22596
> 	   txrx and fp fs rpc queues receqive queues ended up using
> the same tail pointer so the queue full condition was not properly
> detected. 
> 	   Give each queue its own pointer and increase the number of
> entries in the fs rpc queue just in case.


Hi Max,

Please include some or all of the defect header text, not just the
defect number, so that one can tell what defect this checkin is all
about without having to use the defect tool.  Good quality comments
help with sprucing up the software quality as well by making
maintenance easier and more reliable.

Thanks!

a
