AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E08B33EC5@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 3 Mar 2008 15:23:44 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20080303152344.5c13c403@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E08B33EC5@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E08B33EC5@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 3 Mar 2008 14:01:35 -0800 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Change 28132 by maximk@maximk-13 on 2008/03/03 13:53:07 *pending*
> 
>         Use the bit 7 of the 5th byte of the mac address to construct
> the
>            wwns on cougar.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt
> _bus.c#5 edit
> ... //depot/dev/nfx-tree/Includes/cg/NFP_FP/nfx-defs.h#1 add
> ... //depot/dev/nfx-tree/Includes/cg/NFP_TXRX/nfx-defs.h#1 add
> ... //depot/dev/nfx-tree/code/sm-seep/seep-api.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-utils/sys-utils-linux.c#4 edit
> ... //depot/dev/nfx-tree/code/ssc-tests/hostidtest-linux.c#2 edit
> 

linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt_bus.c


     looks good


nfx-tree/Includes/cg/NFP_FP/nfx-defs.h


     >>add nfx-tree/Includes/cg/NFP_FP/nfx-defs.h

     line 13, is there a reason to "hide" this include in another
     include, rather than putting it directly in the C file(s)?


nfx-tree/Includes/cg/NFP_TXRX/nfx-defs.h


     >>add nfx-tree/Includes/cg/NFP_TXRX/nfx-defs.h

     another include file the same as the other one.  is there
     a reason not to just add "#define NFX_EXT_MAC_SLOT 1" to
     Includes/cg/nfx-defs.h?


nfx-tree/code/sm-seep/seep-api.c


     i guess


nfx-tree/code/sm-utils/sys-utils-linux.c


     line 55-56 what, are you some kind of C precence whiz?  please put
     parens around precedence you desire so maintainers don't screw
     it up.


nfx-tree/code/ssc-tests/hostidtest-linux.c

     line 38-39 same thing here with the parens, thank you.

