AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070208133544.2a52b64a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E02215639@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 8 Feb 2007 13:35:51 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Code review?
Message-ID: <20070208133551.655d7a89@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02215639@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E02215639@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I thought you added the fseek awhile ago.  Didn't I already review that?

Anyway, it looks fine.

Cheers,

a

On Thu, 8 Feb 2007 10:55:12 -0800 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
>   I fixed the problem with system compare -s only checking the primary
> flash. When I added the call to verify_install.sh in perform_comapre I
> did a cut and paste and forgot to change the command line option to
> use the compare_secondary rather than upgrade secondary.
> 
> I also added the fseek for the log file so any error output from
> system compare will be placed at the end of the log.
> 
> Let me know how this looks to you or any suggestions or comments.
> 
> Larry
> 
> ==== //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#6 -
> /home/larrys/perforce/trees/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgr
> ade.c ====
> 2478c2478
> <                         patch_location, upgrade_secondary ? "-s" :
> "-p") ;
> ---
> >                         patch_location, compare_secondary ? "-s" :
> "-p") ;
> 2479a2480,2482
> >               if (sys_upgrade) {
> >                       fseek(sys_upgrade, 0, SEEK_END);
> >               }
> 2570a2574
> >
