AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080306110520.1cfe0470@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E03B1C0CB@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 6 Mar 2008 11:05:37 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review 28118
Message-ID: <20080306110537.3b7f41cc@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E03B1C0CB@onstor-exch02.onstor.net>
References: <20080306103042.04fd577f@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E03B1C0CB@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 6 Mar 2008 10:51:55 -0800 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Line 6: OS=`uname` is not used anymore and can be deleted unless you
> want to reference $OS instead of 'uname` in lines 100 & 114.

fixed

> Also since you are in here:  I don't understand why Ian resurrected a
> different SAVELINE setting for Linux.  I thought I reverted this a
> while back but now its come back.  It causes the first comment 3 lines
> repeated (over and over) again when emrscron edits the crontab file.
> Please verify and tell me I'm not seeing things.

Are you saying SAVELINE should be 3 for both OpenBSD and Linux?

> Otherwise than that its ok.
> 
> Rendell
> 
> 
> g7r6:~# crontab -l
> crontab -l
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.1913 installed on Thu Mar  6 09:26:18 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.EqPwIX installed on Thu Mar  6 09:23:30 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.3764 installed on Thu Mar  6 09:19:50 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.J09YdQ installed on Thu Mar  6 09:04:49 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.3066 installed on Thu Mar  6 09:01:41 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.sXrzfl installed on Thu Mar  6 09:00:46 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.5442 installed on Thu Mar  6 08:55:29 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.NApy4k installed on Wed Mar  5 18:53:16 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.1286 installed on Wed Mar  5 11:53:41 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.Ju9l8D installed on Wed Mar  5 11:52:24 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.1338 installed on Wed Mar  5 11:50:32 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.8EnjKh installed on Wed Mar  5 11:37:57 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.1307 installed on Wed Mar  5 11:36:07 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.aChXum installed on Wed Mar  5 11:32:21 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.1301 installed on Wed Mar  5 11:28:48 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.4VcYVm installed on Wed Mar  5 11:26:24 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.2880 installed on Wed Mar  5 11:24:28 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.nevHli installed on Wed Mar  5 09:02:20 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.9113 installed on Wed Mar  5 09:00:24 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/crontab.NofF1n installed on Wed Mar  5 08:57:13 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.10428 installed on Tue Mar  4 16:19:38 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> # DO NOT EDIT THIS FILE - edit the master and reinstall.
> # (/tmp/_crontmp.9471 installed on Tue Mar  4 15:49:32 2008)
> # (Cron version -- $Id: crontab.c,v 2.13 1994/01/17 03:20:37 vixie Exp
> $)
> 
> # gather config every day (at 23:05)
> 5       23      *       *       *       /onstor/bin/emrscron -g config
> 
> # gather stats every hour (on the half hour)
> 30      *       *       *       *       /onstor/bin/emrscron -g stats
> 
> # gather h_res_stats data every 3 min
> */3     *       *       *       *       /onstor/bin/emrscron -g
> h_res_stats
> 
> # keep the last 7 days of config and stats files (removing excess
> daily at 00:53)
> 53      0       *       *       *       /onstor/bin/emrscron -t
> config; /onstor/bin/emrscron -t stats
> 
> # roll the log files for h_res_stats and keep only 7 log files around;
> send files to onstor
> 59      23      *       *       *       /onstor/bin/emrscron -t
> h_res_stats; /onstor/bin/emrscron -s all
> 
> # send the kpi file every hour (the actual minute of this cron job is
> random; seeded by the mac address, so not all field machines send at
> the same time)
> 29      *       *       *       *       /onstor/bin/emrscron -s
> kpi_stats
> g7r6:~#
> 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, March 06, 2008 10:31 AM
> To: Rendell Fong
> Subject: please review 28118
> 
> Change 28118 by andys@ripper on 2008/02/29 13:43:00 *pending*
> 
>         Fix spurious error messages on Linux about
>         newsyslog and killing itself and so on.
>         
>         Also get rid of a huge pustule of trailing whitespace.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-support/emrscron#16 edit
> 
