AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080310133042.502f7cbf@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<jonathan.goldick@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E08C0FA5E@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 10 Mar 2008 13:30:59 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Jonathan Goldick" <jonathan.goldick@onstor.com>
Subject: Re: please review 28169
Message-ID: <20080310133059.40a1d0b8@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E08C0FA5E@onstor-exch02.onstor.net>
References: <20080310101044.773bdb08@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08C0F917@onstor-exch02.onstor.net>
	<20080310120729.0b764ef5@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08C0FA5E@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

The script should be fine for that.  I use tkdiff, and it requires
paths.  Unless you mean something else by 'paths'.


On Mon, 10 Mar 2008 12:14:43 -0700 "Jonathan Goldick"
<jonathan.goldick@onstor.com> wrote:

> I prefer to use my vslick diff tool but it uses paths.
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Monday, March 10, 2008 12:07 PM
> To: Jonathan Goldick
> Subject: Re: please review 28169
> 
> the command
> p4 -c <client> have /depot/whatever
> will give you that information.
> 
> If you haven't tried the review script, try it, you might like it.
> Especially after you've customized it to suit.  There are extensive
> comments at the beginning that might even be partially relevant.
> 
> /n/software/dev-tools/code-review-script.sh
> 
> Cheers,
> 
> a
> 
> On Mon, 10 Mar 2008 10:23:07 -0700 "Jonathan Goldick"
> <jonathan.goldick@onstor.com> wrote:
> 
> > Where are these files located in your tree?
> > 
> > I need a location so I can diff.
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Monday, March 10, 2008 10:11 AM
> > To: Jonathan Goldick
> > Subject: please review 28169
> > 
> > Change 28169 by andys@ripper on 2008/03/04 17:55:23 *pending*
> > 
> > 	Fix DEBUG macro in ide-cs when there is no debugging turned
> > on.
> > 
> > 	Replace call to panic in mgmt-bus.c with an OOPS instead
> > that kills the thread.  This gives the machine a fighting chance to
> > stay alive, or at least reboot with dignity via a process monitor
> > utility. It also is supposed to give us a stack trace that might
> > help us in tracking down some of these.
> > 
> > 	Sync git repository with perforce.
> > 
> > 	reviewed by
> > 
> > Affected files ...
> > 
> > ...
> > //depot/dev/linux/kernel/linux-mips-2.6/drivers/ide/legacy/ide-cs.c#4
> > edit ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c#
> > 8
> > edit ... //depot/dev/linux/kernel/linux-mips-2.6/.git/FETCH_HEAD#6
> > edit ... //depot/dev/linux/kernel/linux-mips-2.6/.git/HEAD#3 edit
> > ... //depot/dev/linux/kernel/linux-mips-2.6/.git/ORIG_HEAD#6 edit
> > ... //depot/dev/linux/kernel/linux-mips-2.6/.git/index#7 edit
> > ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/15/616cbe83d390f6d9
> > 0b6e339c1790c7813940ec#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/34/3f961ee8a638b816
> > 957b84aadacf9f8ee3d1f4#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/68/95a36eb5fdccd8a8
> > dc5a58b4e1cac178df05af#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/68/d8d7c657585c5631
> > 8abd5f7f740ca4e4ea3e20#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/6a/6422f123676b64f8
> > d72f4ba3678c24a53c2acc#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/71/24aca93dde1ec54c
> > b827a6e4aaec1dac231ed7#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/73/cc45b6c4738ee2d3
> > 7f1b3fa3dbcad68ad03615#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/7c/c22f6ba9463a957c
> > a561ecc0402560cef3d377#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/7e/26cacd56f711374a
> > c173ae786508699f8e002e#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/88/a2a7293d27a151f1
> > 90a7832c0b64c6bb1737a4#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/9d/c0ef55fd03003cfa
> > faa14f020c2679841eeae5#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/a0/96db79f94889fa62
> > caebea22a893a2edf97295#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/a1/51f6fc3e10dc9de8
> > 0d01bfab2d38ce7f3b1100#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/af/5b777bfbba70e79c
> > 399d3a7504573b13208f45#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/d0/cb4c88f445be9b55
> > 34421e7025111d08de926c#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/d5/a5807fbfb56a1b25
> > f0363a8856eec667203b17#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/ec/9b52bbe7e76a1c78
> > 3a17392df9b870cff6dbe9#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/objects/f9/c5988d836ab2b405
> > 5e02deaa253cd684a5e1c0#1
> > add ...
> >
> //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-2.6.22#3
> > edit
> > 
