AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080311173017.15f9de29@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9468@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 11 Mar 2008 17:30:27 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Prom upgrade runtime changes
Message-ID: <20080311173027.52fbbebb@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9468@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E08D29F3A@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9468@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Your a damn easy date, Larry.  Except for the strncpy comment.  F@ck
that stupid coverity tool.  It shouldn't be used on our code, and it
definitely shouldn't be used on PROM code.

I'm still working on my review of this.  And seven other things.

On Tue, 11 Mar 2008 17:15:16 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> nfx-tree/code/sm-prom-upgrade/from-upgrade.c
> 
>  
> 
>      looks good
> 
>  
> 
> nfx-tree/code/sm-prom-upgrade/prom-part-api.h
> 
>  
> 
>      looks good
> 
>  
> 
> nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c
> 
>  
> 
>      line 127 you might get future grief for using strcpy versus
> 
>      strncpy.  Perhaps you should change this to keep Coverity from
> 
>      flagging it as a defect and then you won't have to worry about
> 
>      some HCL guy bollixing up your code.
> 
>  
> 
> nfx-tree/code/ssc-nfxsh/menu.c
> 
>  
> 
>      looks good
> 
>  
> 
> nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c
> 
>  
> 
>      Not reviewed. Check with Andy
> 
>  
> 
> ________________________________
> 
> From: Warren Gale 
> Sent: Tuesday, March 11, 2008 11:59 AM
> To: Larry Scheer
> Subject: FW: Prom upgrade runtime changes
> 
>  
> 
> Larry,
> 
>   I'd like to get this in on the next build.
> 
> I sent this to Andy S.   Thought I'd also send you a copy.
> 
>  
> 
> Thanks, and for the p4 help too.
> 
> Warren
> 
>  
> 
> ________________________________
> 
> From: Warren Gale 
> Sent: Tuesday, March 11, 2008 11:38 AM
> To: Andy Sharp
> Subject: Prom upgrade runtime changes
> 
>  
> 
> Andy,
> 
>   Please review.
> Thanks,
> 
> Warren
> 
>  
> 
> Change 28170 by warreng@warreng-cougar on 2008/03/04 18:05:31
> *pending*
> 
>  
> 
>         Fix to /onstor/bin/prom-upgrade command.
> 
>         Fix was to get prom-upgrade app Id and use it as 1st param to
> sendAgileMsg.
> 
>         Add support for cougar prom partitions.
> 
>         fix nfxsh prom upgrade command.  (for Cougar, only FP and TXRX
> are upgraded)
> 
>         fix to nfxsh prom upgrade files command.
> 
>         Now able to get a tar.gz file from upgrade server.
> 
>  
> 
> Affected files ...
> 
>  
> 
> ... //depot/dev/nfx-tree/code/sm-prom-upgrade/from-upgrade.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/sm-prom-upgrade/prom-part-api.h#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#11 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#10 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c#5 edit
> 
>  
> 
