AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080311181620.60b73c80@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<warren.gale@onstor.com>,<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E08D2A198@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 11 Mar 2008 18:17:29 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Warren Gale" <warren.gale@onstor.com>
Cc: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Prom upgrade runtime changes
Message-ID: <20080311181729.64c51a74@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E08D2A198@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E08D29F3A@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9468@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08D2A198@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

My comments:

nfx-tree/code/sm-prom-upgrade/from-upgrade.c


     this is your code, but this is damn ugly.  shouldn't you set
     PART_DESC_SIBYTE_FP_LAYOUT to be the right value for cougar
     instead of adding yet another nasty ifdef?  i leave it up to you.
     do the right thing or your fired.  i kid.


nfx-tree/code/sm-prom-upgrade/prom-part-api.h


     again, i would do a big ifdef COUGAR define these two sibyte
     macros, or define them the previous way.


nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c


     looks ok.  if you can stand variables named 'puout'

     line 503 and friend.  these ifdef COUGARs should have an else
     for the other code that doesn't apply when it's a cougar.

     line 625 don't do this.  put whole, complete assignments inside
     each ifdef block.

     line 1023 is bogus

     rest is ok.  some formatting changes a welcome refreshment.

nfx-tree/code/ssc-nfxsh/menu.c


     looks good


nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c


     holy cauliflower! what's with all the unneccessary whitespace
     changes?  can you please redo this, and delete all the unnecessary
     whitespace changes so I can see the substantive changes?  if there
     is some trailing whitespace that needs cleaning, you can do bits
     of that, but not the whole dang file.  And especially since you
     went the wrong way: converting tabs to spaces.  my lord.





On Tue, 11 Mar 2008 17:51:59 -0700 "Warren Gale"
<warren.gale@onstor.com> wrote:

> Larry,
> 
>  
> 
>     Ok, Cool.  I changed all the strcpy  's  to   strncpy  's  in this
> file.
> 
>     It tested ok also.
> 
> Thanks,
> 
> Warren
> 
>  
> 
> Andy,
> 
>    If you ignore white space on this file there are very few changes..
> 
>  Ie tkdiff -db  
> 
>  
> 
> Thanks,
> 
> Warren
> 
> ________________________________
> 
> From: Larry Scheer 
> Sent: Tuesday, March 11, 2008 5:15 PM
> To: Warren Gale
> Cc: Andy Sharp
> Subject: RE: Prom upgrade runtime changes
> 
>  
> 
> nfx-tree/code/sm-prom-upgrade/from-upgrade.c
> 
>  
> 
>      looks good
> 
>  
> 
> nfx-tree/code/sm-prom-upgrade/prom-part-api.h
> 
>  
> 
>      looks good
> 
>  
> 
> nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c
> 
>  
> 
>      line 127 you might get future grief for using strcpy versus
> 
>      strncpy.  Perhaps you should change this to keep Coverity from
> 
>      flagging it as a defect and then you won't have to worry about
> 
>      some HCL guy bollixing up your code.
> 
>  
> 
> nfx-tree/code/ssc-nfxsh/menu.c
> 
>  
> 
>      looks good
> 
>  
> 
> nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c
> 
>  
> 
>      Not reviewed. Check with Andy
> 
>  
> 
> ________________________________
> 
> From: Warren Gale 
> Sent: Tuesday, March 11, 2008 11:59 AM
> To: Larry Scheer
> Subject: FW: Prom upgrade runtime changes
> 
>  
> 
> Larry,
> 
>   I'd like to get this in on the next build.
> 
> I sent this to Andy S.   Thought I'd also send you a copy.
> 
>  
> 
> Thanks, and for the p4 help too.
> 
> Warren
> 
>  
> 
> ________________________________
> 
> From: Warren Gale 
> Sent: Tuesday, March 11, 2008 11:38 AM
> To: Andy Sharp
> Subject: Prom upgrade runtime changes
> 
>  
> 
> Andy,
> 
>   Please review.
> Thanks,
> 
> Warren
> 
>  
> 
> Change 28170 by warreng@warreng-cougar on 2008/03/04 18:05:31
> *pending*
> 
>  
> 
>         Fix to /onstor/bin/prom-upgrade command.
> 
>         Fix was to get prom-upgrade app Id and use it as 1st param to
> sendAgileMsg.
> 
>         Add support for cougar prom partitions.
> 
>         fix nfxsh prom upgrade command.  (for Cougar, only FP and TXRX
> are upgraded)
> 
>         fix to nfxsh prom upgrade files command.
> 
>         Now able to get a tar.gz file from upgrade server.
> 
>  
> 
> Affected files ...
> 
>  
> 
> ... //depot/dev/nfx-tree/code/sm-prom-upgrade/from-upgrade.c#2 edit
> 
> ... //depot/dev/nfx-tree/code/sm-prom-upgrade/prom-part-api.h#1 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#11 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#10 edit
> 
> ... //depot/dev/nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c#5 edit
> 
>  
> 
