AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080312201130.14518339@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C947D@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 12 Mar 2008 20:12:23 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review
Message-ID: <20080312201223.01824b14@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C947D@onstor-exch02.onstor.net>
References: <20080312200549.7c4e3765@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C947D@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 12 Mar 2008 20:09:22 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Ok will do. But which is faster echo or /bin/hostname? machs nichts
> mine frueind

hostname requires a fork/exec, two expensive system calls.  echo does
neither, it's a bash builtin.  lightning fast.  i'm just sayin'.

> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, March 12, 2008 8:06 PM
> To: Larry Scheer
> Subject: Re: Please review
> 
> Always put the cl# in the subject, otherwise my brilliant email client
> puts messages like this in the last thread with the same message,
> which could have been 10,000 emails and 2 months ago...
> 
> 
> 
> linux/rootfs/etc/onstor/initial-config
> 
>      line 1580 you sure are running /bin/hostname a lot.  why not echo
>      $CURRENT_NODE_NAME > $__MAILNAME_FILE   ??  and what's the
>      "echo -e" all about?
> 
> nfx-tree/Tools/Linux-config-files
> 
>      looks good
> 
> 
> 
> On Wed, 12 Mar 2008 19:37:57 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > I made these changes in my
> > workspace: /home/larrys/perforce/trees/dev located on linux-compile
> > This workspace is mounted on ripper.
> > 
> > Change 28321 by larrys@larrys-r14-dmip on 2008/03/12 19:35:20
> > *pending*
> > 
> >         TED00022322 [Cougar] system time zone does not return
> > current time zone
> >         TED00022311 Cougar - 'system show summary'
> >         error = Time zone : /bin/cat: /etc/timezone: No such file or
> > directory 
> > 
> >         Fix: Add /etc/timezone to the list of Linux configuration
> > files copied and preserved during upgrades and system
> > configure/copy. The OCT was correctly creating the timezone files
> > the only one being preserved and copied was /etc/localtime.
> > 
> >         TED00022315 /etc/mailname are wrong since intial config
> > 
> >         Fix: Add creation of /etc/mailname to OCT.
> > 
> >         Reviewed by: AndyS
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/rootfs/etc/onstor/initial-config#9 edit
> > ... //depot/dev/nfx-tree/Tools/Linux-config-files#4 edit
