AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080313110004.54e5571c@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<warren.gale@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E08DF3315@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 13 Mar 2008 11:03:12 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Warren Gale" <warren.gale@onstor.com>
Subject: Re: Prom upgrade runtime changes
Message-ID: <20080313110312.28e24c7b@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E08DF3315@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E08D29F3A@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9468@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08D2A198@onstor-exch02.onstor.net>
	<20080311181729.64c51a74@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08D2A210@onstor-exch02.onstor.net>
	<20080311195558.6a727e81@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08D2A5BD@onstor-exch02.onstor.net>
	<20080312115546.0df0b4c5@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08DF3315@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I was just thinking I should call you because I hadn't heard back from
you on the review that I sent.  I totally did the review and sent it to
you, and no I can find no trace of the email.  I don't know what
happened.  Very frustrating because there isn't much and it could have
made it into the submittal I'm sure.

Here it is again (luckily the actual review is stored on disk, not as
an email):


nfx-tree/code/sm-prom-upgrade/from-upgrade.c

     line 76  oh, so you still don't want to fix this, eh?  ok, it's
     your funeral!

nfx-tree/code/sm-prom-upgrade/prom-part-api.h

     line 90  see comment for previous file

nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c

     line 211-232 fix spacing - spaces after operators, identifiers
     (except no space between function name and '(') and commas, but
     not before commas or semicolons.  spaces after key words like 'if'
     and 'for'.  no spaces after '('.  you have one for loop like this
     for( i = 1; i < 8; i++ ) {
     which should be like this
     for (i = 1; i < 8; i++) {
     and then you have another like this
     for(j=0; j<2;j++) {
     which is consistent with nothing.

     doRcon is not needed at all.  just put /dev/rcon%d in printf and
     supply the variable i.

     line 422,438,615  don't we have to do this on cheetahs too?
     perhaps it should be ifndef COUGAR?

     line 953 (and others) nice cleanup

nfx-tree/code/ssc-nfxsh/menu.c

     looks good

nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c

     line 576  comment style





On Thu, 13 Mar 2008 10:34:39 -0700 "Warren Gale"
<warren.gale@onstor.com> wrote:

> So is it a yea or nea?
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, March 12, 2008 11:56 AM
> To: Warren Gale
> Subject: Re: Prom upgrade runtime changes
> 
> Nope.  I'll have at it.  Luckily the submittal is still on hold....
> 
> 
> On Wed, 12 Mar 2008 11:42:28 -0700 "Warren Gale"
> <warren.gale@onstor.com> wrote:
> 
> > Ok.  I think I got all the changes in.
> > Just finish re-test.  Looks good..
> > Mind looking at it again?
> > 
> > Thanks,
> > Warren
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Tuesday, March 11, 2008 7:56 PM
> > To: Warren Gale
> > Subject: Re: Prom upgrade runtime changes
> > 
> > On Tue, 11 Mar 2008 19:07:19 -0700 "Warren Gale"
> > <warren.gale@onstor.com> wrote:
> > 
> > > 
> > > Ok, Cool... Thanks.. I'll start working on it..
> > > Please see below ..  <wg>  :)
> > > 
> > > 
> > > 
> > > -----Original Message-----
> > > From: Andy Sharp 
> > > Sent: Tuesday, March 11, 2008 6:17 PM
> > > To: Warren Gale
> > > Cc: Larry Scheer
> > > Subject: Re: Prom upgrade runtime changes
> > > 
> > > My comments:
> > > 
> > > nfx-tree/code/sm-prom-upgrade/from-upgrade.c
> > > 
> > > ---------
> > > <wg>  actually I don't know who did it, I just get to update it...
> > >       I agree that it's ugly, but it is used for Bobcat and
> > > Cheetah as well.  Since the partitions of the PROM have changed
> > > for Cougar, and their sizes, this seemed to work best without
> > > having to make lots of changes other code
> > 
> > You did it.  I'm talking about your changes only here.  You should
> > do it correctly in prom-part-api.h w.r.t my comment for that file.
> > 
> > > ---------  
> > > 
> > >      this is your code, but this is damn ugly.  shouldn't you set
> > >      PART_DESC_SIBYTE_FP_LAYOUT to be the right value for cougar
> > >      instead of adding yet another nasty ifdef?  i leave it up to
> > > you. do the right thing or your fired.  i kid.
> > > 
> > > 
> > > nfx-tree/code/sm-prom-upgrade/prom-part-api.h
> > > 
> > > 
> > >      again, i would do a big ifdef COUGAR define these two sibyte
> > >      macros, or define them the previous way.
> > 
> > Uh, well, that comment could be a little clearer I guess.
> > 
> > > nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c
> > > 
> > > 
> > >      looks ok.  if you can stand variables named 'puout'
> > > 
> > > ---------
> > > <wg>
> > >     Ok Changed  ifdefs here on 503 and friend.. (Like that one)..
> > >     Changed 625 and got rid of 1023... Sorry I missed that one.
> > > ---------
> > 
> > That's why we're here.
> > 
> > 
> > >      line 503 and friend.  these ifdef COUGARs should have an else
> > >      for the other code that doesn't apply when it's a cougar.
> > > 
> > >      line 625 don't do this.  put whole, complete assignments
> > > inside each ifdef block.
> > > 
> > >      line 1023 is bogus
> > > 
> > >      rest is ok.  some formatting changes a welcome refreshment.
> > > 
> > > nfx-tree/code/ssc-nfxsh/menu.c
> > > 
> > > 
> > >      looks good
> > > 
> > > 
> > > nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c
> > > 
> > > -------------
> > > <wg>
> > > http://wiki.onstor.net/wiki/Onstor_Coding_Style_Guide
> > > Whitespace and formatting:
> > > I guess number 1 and number 2 is just plain wrong.
> > 
> > Number 1 is wrong, #2 is right.  Set shift width and tab stop to 4.
> > 
> > Stupid stinkin' Winblows programmers got to this wiki.  I'll fix
> > that. Sorry you got bit.
> > 
> > > Ok, I can put it back. Your call.. :)
> > > (That's what I get for trying to take ownership of a
> > > file :(  stung :) ) -----------
> > 
> > Sorry.  Big whitespace changes make it difficult to track changes.
> > Instead, if you want to format the file in your own way, do a
> > separate, whitespace/style only checkin, that way someone else, or
> > you even, can easily ignore that change just by looking at the
> > comment.  If you want to do that, then feel free to use me as the
> > reviewer.  I'll take the time.
> > 
> > >      holy cauliflower! what's with all the unneccessary whitespace
> > >      changes?  can you please redo this, and delete all the
> > > unnecessary whitespace changes so I can see the substantive
> > > changes? if there is some trailing whitespace that needs
> > > cleaning, you can do bits of that, but not the whole dang file.
> > > And especially since you went the wrong way: converting tabs to
> > > spaces.  my lord.
> > > 
> > > 
> > > 
> > > 
> > > 
> > > On Tue, 11 Mar 2008 17:51:59 -0700 "Warren Gale"
> > > <warren.gale@onstor.com> wrote:
> > > 
> > > > Larry,
> > > > 
> > > >  
> > > > 
> > > >     Ok, Cool.  I changed all the strcpy  's  to   strncpy  's
> > > > in this file.
> > > > 
> > > >     It tested ok also.
> > > > 
> > > > Thanks,
> > > > 
> > > > Warren
> > > > 
> > > >  
> > > > 
> > > > Andy,
> > > > 
> > > >    If you ignore white space on this file there are very few
> > > > changes..
> > > > 
> > > >  Ie tkdiff -db  
> > > > 
> > > >  
> > > > 
> > > > Thanks,
> > > > 
> > > > Warren
> > > > 
> > > > ________________________________
> > > > 
> > > > From: Larry Scheer 
> > > > Sent: Tuesday, March 11, 2008 5:15 PM
> > > > To: Warren Gale
> > > > Cc: Andy Sharp
> > > > Subject: RE: Prom upgrade runtime changes
> > > > 
> > > >  
> > > > 
> > > > nfx-tree/code/sm-prom-upgrade/from-upgrade.c
> > > > 
> > > >  
> > > > 
> > > >      looks good
> > > > 
> > > >  
> > > > 
> > > > nfx-tree/code/sm-prom-upgrade/prom-part-api.h
> > > > 
> > > >  
> > > > 
> > > >      looks good
> > > > 
> > > >  
> > > > 
> > > > nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c
> > > > 
> > > >  
> > > > 
> > > >      line 127 you might get future grief for using strcpy versus
> > > > 
> > > >      strncpy.  Perhaps you should change this to keep Coverity
> > > > from
> > > > 
> > > >      flagging it as a defect and then you won't have to worry
> > > > about
> > > > 
> > > >      some HCL guy bollixing up your code.
> > > > 
> > > >  
> > > > 
> > > > nfx-tree/code/ssc-nfxsh/menu.c
> > > > 
> > > >  
> > > > 
> > > >      looks good
> > > > 
> > > >  
> > > > 
> > > > nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c
> > > > 
> > > >  
> > > > 
> > > >      Not reviewed. Check with Andy
> > > > 
> > > >  
> > > > 
> > > > ________________________________
> > > > 
> > > > From: Warren Gale 
> > > > Sent: Tuesday, March 11, 2008 11:59 AM
> > > > To: Larry Scheer
> > > > Subject: FW: Prom upgrade runtime changes
> > > > 
> > > >  
> > > > 
> > > > Larry,
> > > > 
> > > >   I'd like to get this in on the next build.
> > > > 
> > > > I sent this to Andy S.   Thought I'd also send you a copy.
> > > > 
> > > >  
> > > > 
> > > > Thanks, and for the p4 help too.
> > > > 
> > > > Warren
> > > > 
> > > >  
> > > > 
> > > > ________________________________
> > > > 
> > > > From: Warren Gale 
> > > > Sent: Tuesday, March 11, 2008 11:38 AM
> > > > To: Andy Sharp
> > > > Subject: Prom upgrade runtime changes
> > > > 
> > > >  
> > > > 
> > > > Andy,
> > > > 
> > > >   Please review.
> > > > Thanks,
> > > > 
> > > > Warren
> > > > 
> > > >  
> > > > 
> > > > Change 28170 by warreng@warreng-cougar on 2008/03/04 18:05:31
> > > > *pending*
> > > > 
> > > >  
> > > > 
> > > >         Fix to /onstor/bin/prom-upgrade command.
> > > > 
> > > >         Fix was to get prom-upgrade app Id and use it as 1st
> > > > param to sendAgileMsg.
> > > > 
> > > >         Add support for cougar prom partitions.
> > > > 
> > > >         fix nfxsh prom upgrade command.  (for Cougar, only FP
> > > > and TXRX are upgraded)
> > > > 
> > > >         fix to nfxsh prom upgrade files command.
> > > > 
> > > >         Now able to get a tar.gz file from upgrade server.
> > > > 
> > > >  
> > > > 
> > > > Affected files ...
> > > > 
> > > >  
> > > > 
> > > > ... //depot/dev/nfx-tree/code/sm-prom-upgrade/from-upgrade.c#2
> > > > edit
> > > > 
> > > > ... //depot/dev/nfx-tree/code/sm-prom-upgrade/prom-part-api.h#1
> > > > edit
> > > > 
> > > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#11
> > > > edit
> > > > 
> > > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#10 edit
> > > > 
> > > > ... //depot/dev/nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c#5
> > > > edit
> > > > 
> > > >  
> > > > 
